-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Management] Fix print error log when server return redirect (http code 307). #14259
Merged
codelipenghui
merged 3 commits into
apache:master
from
mattisonchao:fix_print_error_log
Feb 14, 2022
Merged
[Management] Fix print error log when server return redirect (http code 307). #14259
codelipenghui
merged 3 commits into
apache:master
from
mattisonchao:fix_print_error_log
Feb 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertIndie
approved these changes
Feb 14, 2022
RobertIndie
reviewed
Feb 14, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Show resolved
Hide resolved
codelipenghui
approved these changes
Feb 14, 2022
@mattisonchao Please rebase the master branch |
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Show resolved
Hide resolved
hangc0276
reviewed
Feb 14, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Show resolved
Hide resolved
@mattisonchao Thanks for your contribution, please help resolve the conflicts, thanks a lot. |
@hangc0276 @Demogorgon314 @RobertIndie PTAL :) |
Demogorgon314
approved these changes
Feb 14, 2022
RobertIndie
approved these changes
Feb 14, 2022
/pulsarbot rerun-failure-checks |
hangc0276
approved these changes
Feb 14, 2022
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, some RestAPI will print an error log when the server returns the redirect code(307). which can let the user a lit bit confusing.
Modifications
exceptionally
handlers that will make the request timeout.Verifying this change
Documentation
no-need-doc
Q&A
Q: Why remove code as follow:
A: because some methods like
validateTopicOwnershipAsync
already have logged.pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java
Lines 662 to 674 in ed56344
Additional
We have some code like this:
Multiple exception handlers will cause some code complexity, I think we can merge those handlers and refactor method in another PR.