[Issue 13756][Broker]Optimize topic policy with HierarchyTopicPolicies about publishRate #14267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnonHxy
force-pushed
the
opt_publishRate
branch
from
caa4b46
to
ce4c049
Compare
AnonHxy
force-pushed
the
opt_publishRate
branch
from
ce4c049
to
3bf6552
Compare
Jason918
reviewed
Feb 14, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
Outdated
Show resolved
Hide resolved
| topicPolicies.getDelayedDeliveryEnabled().updateTopicValue(data.getDelayedDeliveryEnabled()); | ||
| topicPolicies.getDelayedDeliveryTickTimeMillis().updateTopicValue(data.getDelayedDeliveryTickTimeMillis()); | ||
| topicPolicies.getCompactionThreshold().updateTopicValue(data.getCompactionThreshold()); | ||
| } | ||
|
|
||
| private PublishRate normalize(PublishRate publishRate) { |
There was a problem hiding this comment.
It's better to move this to a static method in PublishRate class.
| topicPolicies.getDelayedDeliveryEnabled().updateTopicValue(data.getDelayedDeliveryEnabled()); | ||
| topicPolicies.getDelayedDeliveryTickTimeMillis().updateTopicValue(data.getDelayedDeliveryTickTimeMillis()); | ||
| topicPolicies.getCompactionThreshold().updateTopicValue(data.getCompactionThreshold()); | ||
| } | ||
|
|
||
| private PublishRate normalize(PublishRate publishRate) { |
There was a problem hiding this comment.
It's better to move this to a static method in PublishRate class.
AnonHxy
changed the title
AnonHxy
force-pushed
the
opt_publishRate
branch
from
0787b18
to
353f93f
Compare
AnonHxy
force-pushed
the
opt_publishRate
branch
from
353f93f
to
1ea7071
Compare
23 tasks
eolivelli
reviewed
Feb 15, 2022
| @@ -1061,7 +1044,8 @@ protected boolean isExceedMaximumMessageSize(int size, PublishContext publishCon | |||
| /** | |||
| * update topic publish dispatcher for this topic. | |||
| */ | |||
| protected void updatePublishDispatcher(PublishRate publishRate) { | |||
| public void updatePublishDispatcher() { | |||
| PublishRate publishRate = topicPolicies.getPublishRate().get(); | |||
There was a problem hiding this comment.
It can not return null, I will remove the if (publishRate != null below @eolivelli
AnonHxy
changed the title
eolivelli
approved these changes
Feb 15, 2022
Jason918
approved these changes
Feb 16, 2022
codelipenghui
approved these changes
Feb 16, 2022
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
…s about publishRate (apache#14267)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #13756
Motivation
See issue: #13756
Modifications
publishRateinorg.apache.pulsar.common.policies.data.HierarchyTopicPoliciespublishRateinorg.apache.pulsar.broker.service.AbstractTopicVerifying this change
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
no-need-doc