Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transaction] Optimize changeToCloseState #14277

Merged
merged 1 commit into from
Feb 16, 2022
Merged

[Transaction] Optimize changeToCloseState #14277

merged 1 commit into from
Feb 16, 2022

Conversation

liangyepianzhou
Copy link
Contributor

Motivation

The four judgments are not atomic. If there is a state transition in the judgment, errors may occur. For example, in state_ UPDATER. When compareandset (this, state. None, state. Close) is selected, the state of TB changes from nosnapshot to ready, then this changeToClosed will fail.

Modification

change to STATE_UPDATER.set(this, State.Close);

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly (if you have committer privilege).

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

### Motivation
The four judgments are not atomic. If there is a state transition in the judgment, errors may occur. For example, in ` state_ UPDATER. When compareandset (this, state. None, state. Close) ` is selected, the state of TB changes from nosnapshot to ready, then this changeToClosed will fail.
### Modification
change to `STATE_UPDATER.set(this, State.Close);`
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 14, 2022
@codelipenghui codelipenghui added this to the 2.11.0 milestone Feb 15, 2022
@liangyepianzhou
Copy link
Contributor Author

/pulsarbot run-failure-checks

@congbobo184 congbobo184 merged commit 3d90165 into apache:master Feb 16, 2022
@codelipenghui codelipenghui modified the milestones: 2.11.0, 2.10.0 Feb 17, 2022
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
### Motivation
The four judgments are not atomic. If there is a state transition in the judgment, errors may occur. For example, in ` state_ UPDATER. When compareandset (this, state. None, state. Close) ` is selected, the state of TB changes from nosnapshot to ready, then this changeToClosed will fail.
### Modification
change to `STATE_UPDATER.set(this, State.Close);`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants