[Transaction] Optimize testEndTBRecoveringWhenManagerLedgerDisReadable #14303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation The time used by clean up is too long. This is because the broker service fails to execute the unloadserviceunit, and can only rely on the timeout mechanism to cancel the unloadserviceunit this time. As a result, the clean up takes too much time. The root cause is that there is a mock cursor in managerledger cursors. ### Modification remove the cursor after test
codelipenghui
approved these changes
Feb 16, 2022
congbobo184
approved these changes
Feb 16, 2022
gaoran10
pushed a commit
that referenced
this pull request
Mar 1, 2022
#14303) ### Motivation The time used by clean up is too long. This is because the broker service fails to execute the `unloadserviceunit`, and can only rely on the timeout mechanism to cancel the `unloadserviceunit` this time. As a result, the clean up takes too much time. The root cause is that there is a mock cursor in `ManagerLedger.cursors`. ### Modification Remove the cursor from `ManagerLedger.cursors` after test. (cherry picked from commit a43fab0)
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
apache#14303) ### Motivation The time used by clean up is too long. This is because the broker service fails to execute the `unloadserviceunit`, and can only rely on the timeout mechanism to cancel the `unloadserviceunit` this time. As a result, the clean up takes too much time. The root cause is that there is a mock cursor in `ManagerLedger.cursors`. ### Modification Remove the cursor from `ManagerLedger.cursors` after test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The time used by clean up is too long.
This is because the broker service fails to execute the
unloadserviceunit, and can only rely on the timeout mechanism to cancel theunloadserviceunitthis time. As a result, the clean up takes too much time. The root cause is that there is a mock cursor inManagerLedger.cursors.Modification
Remove the cursor from
ManagerLedger.cursorsafter test.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)