[CI]Upgrade Windows runner os to windows-2022 and generator #14368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaalsn
changed the title
nicoloboschi
approved these changes
Feb 18, 2022
|
@BewareMyPower PTAL |
BewareMyPower
approved these changes
Feb 18, 2022
mattisonchao
approved these changes
Feb 18, 2022
|
@codelipenghui Should we cherry-pick this PR to branch-2.10 at this moment? It affects the CI. But I see 2.10.0 is not released yet. |
BewareMyPower
pushed a commit
that referenced
this pull request
Feb 18, 2022
… Studio 17 2022 (#14368) ### Motivation As github windows runner latest upgrade to [2022](actions/runner-images#4856), the `ci-cpp-build-windows.yaml` workflow should be changed otherwise the action would be failed such as [this one](https://github.com/apache/pulsar/actions/runs/1860147632) ### Modifications - Upgrade os version to 2022 - Change generator to `Visual Studio 17 2022` (cherry picked from commit 0facd24)
BewareMyPower
pushed a commit
that referenced
this pull request
Feb 18, 2022
… Studio 17 2022 (#14368) ### Motivation As github windows runner latest upgrade to [2022](actions/runner-images#4856), the `ci-cpp-build-windows.yaml` workflow should be changed otherwise the action would be failed such as [this one](https://github.com/apache/pulsar/actions/runs/1860147632) ### Modifications - Upgrade os version to 2022 - Change generator to `Visual Studio 17 2022` (cherry picked from commit 0facd24)
gaozhangmin
pushed a commit
to gaozhangmin/pulsar
that referenced
this pull request
Feb 18, 2022
… Studio 17 2022 (apache#14368) ### Motivation As github windows runner latest upgrade to [2022](actions/runner-images#4856), the `ci-cpp-build-windows.yaml` workflow should be changed otherwise the action would be failed such as [this one](https://github.com/apache/pulsar/actions/runs/1860147632) ### Modifications - Upgrade os version to 2022 - Change generator to `Visual Studio 17 2022`
|
@BewareMyPower Yes, I have cherry-picked into branch-2.10 and will contain this fix in 2.10.0 |
codelipenghui
pushed a commit
that referenced
this pull request
Feb 25, 2022
… Studio 17 2022 (#14368) ### Motivation As github windows runner latest upgrade to [2022](actions/runner-images#4856), the `ci-cpp-build-windows.yaml` workflow should be changed otherwise the action would be failed such as [this one](https://github.com/apache/pulsar/actions/runs/1860147632) ### Modifications - Upgrade os version to 2022 - Change generator to `Visual Studio 17 2022` (cherry picked from commit 0facd24)
nicoloboschi
pushed a commit
to nicoloboschi/pulsar
that referenced
this pull request
Mar 1, 2022
… Studio 17 2022 (apache#14368) ### Motivation As github windows runner latest upgrade to [2022](actions/runner-images#4856), the `ci-cpp-build-windows.yaml` workflow should be changed otherwise the action would be failed such as [this one](https://github.com/apache/pulsar/actions/runs/1860147632) ### Modifications - Upgrade os version to 2022 - Change generator to `Visual Studio 17 2022`
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
… Studio 17 2022 (apache#14368) ### Motivation As github windows runner latest upgrade to [2022](actions/runner-images#4856), the `ci-cpp-build-windows.yaml` workflow should be changed otherwise the action would be failed such as [this one](https://github.com/apache/pulsar/actions/runs/1860147632) ### Modifications - Upgrade os version to 2022 - Change generator to `Visual Studio 17 2022`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As github windows runner latest upgrade to 2022, the
ci-cpp-build-windows.yamlworkflow should be changed otherwise the action would be failed such as this oneModifications
Visual Studio 17 2022Verifying this change
Documentation
no-need-doc