Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transaction] Fix end transaction at state of timeout #14370

Merged
merged 1 commit into from
Feb 25, 2022
Merged

[Transaction] Fix end transaction at state of timeout #14370

merged 1 commit into from
Feb 25, 2022

Conversation

liangyepianzhou
Copy link
Contributor

Motivation

For concurrency problems, timeout may change the status to timeout before commit/abort changes the status to committing/aborting.

Modification

Cancel timeout when commit or abort and then check the state.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly (if you have committer privilege).

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

### Motivation
For concurrency problems, timeout may change the status to timeout before commit/abort changes the status to committing/aborting.
### Modification
Cancel timeout when commit or abort and then check the state.
@codelipenghui codelipenghui merged commit 4b48045 into apache:master Feb 25, 2022
codelipenghui pushed a commit that referenced this pull request Feb 25, 2022
### Motivation
For concurrency problems, timeout may change the status to timeout before commit/abort changes the status to committing/aborting.

### Modification
Cancel timeout when commit or abort and then check the state.

(cherry picked from commit 4b48045)
@codelipenghui codelipenghui modified the milestones: 2.11.0, 2.10.0 Feb 25, 2022
gaoran10 pushed a commit that referenced this pull request Mar 1, 2022
### Motivation
For concurrency problems, timeout may change the status to timeout before commit/abort changes the status to committing/aborting.

### Modification
Cancel timeout when commit or abort and then check the state.

(cherry picked from commit 4b48045)
@gaoran10 gaoran10 added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Mar 2, 2022
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
### Motivation
For concurrency problems, timeout may change the status to timeout before commit/abort changes the status to committing/aborting.

### Modification
Cancel timeout when commit or abort and then check the state.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/transaction cherry-picked/branch-2.9 Archived: 2.9 is end of life doc-not-needed Your PR changes do not impact docs release/2.9.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants