[C++] Fix thread safety issue for multi topic consumer #14380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Motivation** In C++ client, if a consumer subscribes multiple topics, a `MultiTopicsConsumerImpl` object, which manages a vector of `ConsumerImpl`s (`consumers_` field), will be created. However, `consumers_` could be accessed by multiple threads, while no mutex is locked to protect the access to make it thread safe. **Modifications** - Add a `SynchronizedHashMap` class, which implements some thread safe methods of traverse, remove, find, clear operations. Since the `forEach` methods could call other methods, use the recursive mutex instead of the default mutex. - Add a related test `SynchronizedHashMapTest` to test the methods and the thread safety of `SynchronizedHashMap`. - Use `SynchronizedHashMap` as the type of `MultiTopicsConsumerImpl::consumers_`.
BewareMyPower
added
type/bug
BewareMyPower
requested review from
merlimat,
rdhabalia,
jiazhai,
aahmed-se,
k2la and
massakam
4 tasks
|
Hi @merlimat could you take a look at this PR? |
merlimat
approved these changes
Mar 10, 2022
gaoran10
added
cherry-picked/branch-2.9
gaoran10
pushed a commit
that referenced
this pull request
Mar 11, 2022
* [C++] Fix thread safety issue for multi topic consumer **Motivation** In C++ client, if a consumer subscribes multiple topics, a `MultiTopicsConsumerImpl` object, which manages a vector of `ConsumerImpl`s (`consumers_` field), will be created. However, `consumers_` could be accessed by multiple threads, while no mutex is locked to protect the access to make it thread safe. **Modifications** - Add a `SynchronizedHashMap` class, which implements some thread safe methods of traverse, remove, find, clear operations. Since the `forEach` methods could call other methods, use the recursive mutex instead of the default mutex. - Add a related test `SynchronizedHashMapTest` to test the methods and the thread safety of `SynchronizedHashMap`. - Use `SynchronizedHashMap` as the type of `MultiTopicsConsumerImpl::consumers_`. * Add findFirstValueIf method * Remove unnecessary return value of forEach * Fix incorrect calls of forEachValue * Add missed header (cherry picked from commit f94eba9)
codelipenghui
pushed a commit
that referenced
this pull request
Mar 12, 2022
* [C++] Fix thread safety issue for multi topic consumer **Motivation** In C++ client, if a consumer subscribes multiple topics, a `MultiTopicsConsumerImpl` object, which manages a vector of `ConsumerImpl`s (`consumers_` field), will be created. However, `consumers_` could be accessed by multiple threads, while no mutex is locked to protect the access to make it thread safe. **Modifications** - Add a `SynchronizedHashMap` class, which implements some thread safe methods of traverse, remove, find, clear operations. Since the `forEach` methods could call other methods, use the recursive mutex instead of the default mutex. - Add a related test `SynchronizedHashMapTest` to test the methods and the thread safety of `SynchronizedHashMap`. - Use `SynchronizedHashMap` as the type of `MultiTopicsConsumerImpl::consumers_`. * Add findFirstValueIf method * Remove unnecessary return value of forEach * Fix incorrect calls of forEachValue * Add missed header (cherry picked from commit f94eba9)
codelipenghui
pushed a commit
that referenced
this pull request
Mar 18, 2022
* [C++] Fix thread safety issue for multi topic consumer **Motivation** In C++ client, if a consumer subscribes multiple topics, a `MultiTopicsConsumerImpl` object, which manages a vector of `ConsumerImpl`s (`consumers_` field), will be created. However, `consumers_` could be accessed by multiple threads, while no mutex is locked to protect the access to make it thread safe. **Modifications** - Add a `SynchronizedHashMap` class, which implements some thread safe methods of traverse, remove, find, clear operations. Since the `forEach` methods could call other methods, use the recursive mutex instead of the default mutex. - Add a related test `SynchronizedHashMapTest` to test the methods and the thread safety of `SynchronizedHashMap`. - Use `SynchronizedHashMap` as the type of `MultiTopicsConsumerImpl::consumers_`. * Add findFirstValueIf method * Remove unnecessary return value of forEach * Fix incorrect calls of forEachValue * Add missed header (cherry picked from commit f94eba9)
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
* [C++] Fix thread safety issue for multi topic consumer **Motivation** In C++ client, if a consumer subscribes multiple topics, a `MultiTopicsConsumerImpl` object, which manages a vector of `ConsumerImpl`s (`consumers_` field), will be created. However, `consumers_` could be accessed by multiple threads, while no mutex is locked to protect the access to make it thread safe. **Modifications** - Add a `SynchronizedHashMap` class, which implements some thread safe methods of traverse, remove, find, clear operations. Since the `forEach` methods could call other methods, use the recursive mutex instead of the default mutex. - Add a related test `SynchronizedHashMapTest` to test the methods and the thread safety of `SynchronizedHashMap`. - Use `SynchronizedHashMap` as the type of `MultiTopicsConsumerImpl::consumers_`. * Add findFirstValueIf method * Remove unnecessary return value of forEach * Fix incorrect calls of forEachValue * Add missed header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In C++ client, if a consumer subscribes multiple topics, a
MultiTopicsConsumerImplobject, which manages a vector ofConsumerImpls (consumers_field), will be created. However,consumers_could be accessed by multiple threads, while nomutex is locked to protect the access to make it thread safe.
Modifications
SynchronizedHashMapclass, which implements some thread safemethods of traverse, remove, find, clear operations. Since the
forEachmethods could call other methods, use the recursive mutexinstead of the default mutex.
SynchronizedHashMapTestto test the methods andthe thread safety of
SynchronizedHashMap.SynchronizedHashMapas the type ofMultiTopicsConsumerImpl::consumers_.