[Broker] Fix Future.join() causing deadlock.
#14469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
eolivelli
requested changes
Feb 25, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
michaeljmarshall
requested changes
Feb 25, 2022
There was a problem hiding this comment.
@mattisonchao - thanks for opening the PR. I left some feedback.
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
mattisonchao
requested review from
eolivelli,
michaeljmarshall and
codelipenghui
|
/pulsarbot rerun-failure-checks |
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
|
/pulsarbot rerun-failure-checks |
Jason918
reviewed
Feb 27, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Show resolved
Hide resolved
eolivelli
requested changes
Feb 27, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Show resolved
Hide resolved
Jason918
approved these changes
Feb 27, 2022
gaoran10
approved these changes
Feb 27, 2022
eolivelli
approved these changes
Feb 27, 2022
codelipenghui
approved these changes
Feb 28, 2022
|
@Jason918 @eolivelli |
|
PTAL :) |
RobertIndie
approved these changes
Feb 28, 2022
Technoboy-
reviewed
Feb 28, 2022
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentTopicE2ETest.java
Show resolved
Hide resolved
Technoboy-
approved these changes
Feb 28, 2022
Jason918
approved these changes
Feb 28, 2022
|
@michaeljmarshall could you please take a final look ? |
michaeljmarshall
requested changes
Feb 28, 2022
There was a problem hiding this comment.
@mattisonchao - PTAL. I will approve and merge this once we agree on my comment, thanks!
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
…ersistent/PersistentTopic.java Co-authored-by: Michael Marshall <mikemarsh17@gmail.com>
michaeljmarshall
approved these changes
Mar 1, 2022
|
Just in case anyone is looking for more context, one of my concerns with the initial implementation had to do with unsafe publication of mutable state, which can behave in unexpected ways. I explain this more in this comment #14469 (comment) |
4 tasks
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
Master issue apache#14438 ### Motivation Invoking the ``join()`` method in the async method will cause some deadlock. ### Modifications - Refactor ``PersistentTopic#tryToDeletePartitionedMetadata`` to pure async.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master issue #14438
Motivation
Invoking the
join()method in the async method will cause some deadlock.Modifications
PersistentTopic#tryToDeletePartitionedMetadatato pure async.Verifying this change
Documentation
no-need-doc