[fix][transaction] avoid too many ServiceUnitNotReadyException for transaction buffer handler #14894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
added
area/transaction
type/bug
codelipenghui
added
release/2.9.3
release/2.10.1
and removed
doc-not-needed
|
@codelipenghui:Thanks for your contribution. For this PR, do we need to update docs? |
Anonymitaet
added
doc-not-needed
|
/pulsarbot run-failure-checks |
codelipenghui
requested review from
congbobo184,
eolivelli,
merlimat and
gaoran10
congbobo184
reviewed
Mar 30, 2022
| @@ -87,7 +96,18 @@ public TransactionBufferHandlerImpl(PulsarClient pulsarClient, | |||
| long requestId = requestIdGenerator.getAndIncrement(); | |||
| ByteBuf cmd = Commands.newEndTxnOnPartition(requestId, txnIdLeastBits, txnIdMostBits, | |||
| topic, action, lowWaterMark); | |||
| return endTxn(requestId, topic, cmd, cb); | |||
|
|
|||
| try { | |||
There was a problem hiding this comment.
this try catch can be deleted, below all
There was a problem hiding this comment.
lookupCache.get(topic) will throw ExecutionException which means some errors happened in the lookup cache, we need to catch the exception and invalidate the cache.
| REQUEST_CREDITS_UPDATER.incrementAndGet(this); | ||
| } | ||
| } else { | ||
| checkPendingRequests(); |
There was a problem hiding this comment.
only continue; is enough
| response.getError()); | ||
| cache.invalidate(op.topic); | ||
| op.cb.completeExceptionally(ClientCnx.getPulsarClientException(response.getError(), response.getMessage())); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
does we need this try catch?
There was a problem hiding this comment.
Just want to add an error log if there are some exceptions when completing the callback, the final block ensure the onResponse() can be complete.
congbobo184
approved these changes
Mar 30, 2022
codelipenghui
force-pushed
the
penghui/transaction_buffer_handler_permits
branch
from
515a987
to
45aed4e
Compare
codelipenghui
force-pushed
the
penghui/transaction_buffer_handler_permits
branch
from
45aed4e
to
9b109db
Compare
…ansaction buffer handler 1.Added max outstanding requests limit 2.Add the request to pending request after reach the max outstanding requests 3.Avoid duplicated lookup cache invalidation
codelipenghui
force-pushed
the
penghui/transaction_buffer_handler_permits
branch
from
9c03a0f
to
b9f1b79
Compare
codelipenghui
added a commit
that referenced
this pull request
Apr 19, 2022
…ansaction buffer handler (#14894) ### Motivation 1. Added max concurrent request limitation for transaction buffer client 2. Add the request to the pending request queue after reaching the concurrent request limitation 3. Avoid duplicated lookup cache invalidation (cherry picked from commit 384c528)
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
…ansaction buffer handler (apache#14894) ### Motivation 1. Added max concurrent request limitation for transaction buffer client 2. Add the request to the pending request queue after reaching the concurrent request limitation 3. Avoid duplicated lookup cache invalidation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)