Skip unnecessary DNS resolution when creating AuthenticationDataHttp instance #15221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
added
type/enhancement
lhotari
requested review from
codelipenghui,
eolivelli,
merlimat and
michaeljmarshall
eolivelli
approved these changes
Apr 19, 2022
lhotari
added a commit
to lhotari/pulsar
that referenced
this pull request
Apr 20, 2022
…tp instance - improves solution added in apache#15221 - It's better to use the JDK provided InetSocketAddress.createUnresolved method to prevent unnecessary DNS resolution
|
I created a follow up PR #15228 since in this case, the use of |
lhotari
added a commit
to datastax/pulsar
that referenced
this pull request
Apr 20, 2022
…instance (apache#15221) (cherry picked from commit 14991c9)
lhotari
added a commit
to datastax/pulsar
that referenced
this pull request
Apr 20, 2022
…tp instance (apache#15228) - improves solution added in apache#15221 - It's better to use the JDK provided InetSocketAddress.createUnresolved method to prevent unnecessary DNS resolution (cherry picked from commit e71b98a)
lhotari
added a commit
to datastax/pulsar
that referenced
this pull request
Apr 21, 2022
…instance (apache#15221) (cherry picked from commit 14991c9)
lhotari
added a commit
to datastax/pulsar
that referenced
this pull request
Apr 21, 2022
…tp instance (apache#15228) - improves solution added in apache#15221 - It's better to use the JDK provided InetSocketAddress.createUnresolved method to prevent unnecessary DNS resolution (cherry picked from commit e71b98a)
lhotari
added a commit
to datastax/pulsar
that referenced
this pull request
Apr 21, 2022
…instance (apache#15221) (cherry picked from commit 14991c9)
lhotari
added a commit
to datastax/pulsar
that referenced
this pull request
Apr 21, 2022
…tp instance (apache#15228) - improves solution added in apache#15221 - It's better to use the JDK provided InetSocketAddress.createUnresolved method to prevent unnecessary DNS resolution (cherry picked from commit e71b98a)
|
@lhotari This and the follow up commits are labelled with 2.10 but I don't see the related changes on branch-2.10 https://github.com/apache/pulsar/blob/branch-2.10/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationDataHttp.java |
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 28, 2022
…instance (apache#15221) (cherry picked from commit 14991c9)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 28, 2022
…tp instance (apache#15228) - improves solution added in apache#15221 - It's better to use the JDK provided InetSocketAddress.createUnresolved method to prevent unnecessary DNS resolution (cherry picked from commit e71b98a)
Jason918
added
cherry-picked/branch-2.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Using the DNS resolution is a blocking operation in Java. In this case it's completely unnecessary to do a reverse lookup for the client's IP address.
Modifications