[Python] Adjusted script to build wheel for Python 3.7 on Mac #15407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
area/build
component/client-python
doc-not-needed
Technoboy-
approved these changes
May 3, 2022
merlimat
added a commit
that referenced
this pull request
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix apache/pulsar-client-python#51
In the
build-mac-wheels.shscript we were not building the wheel for Python 3.7. We need to treat 3.7 in a slightly different way because it has no support for Mac M1 binaries (universal2which support was added in Python 3.8). Therefore for Python 3.7 we're going to build anx86_64only wheel file, cross compiling is the build is happening on an M1 Mac.