Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][broker] Make some operation subscription dispatchRate methods in Namespaces async #15880

Merged
merged 10 commits into from Jun 17, 2022
Merged

[improve][broker] Make some operation subscription dispatchRate methods in Namespaces async #15880

merged 10 commits into from Jun 17, 2022

Conversation

gaoyanliang
Copy link
Contributor

@gaoyanliang gaoyanliang commented Jun 1, 2022 •
edited

Motivation

See PIP #14365 and change tracker #15043.

Make setSubscriptionDispatchRate / getSubscriptionDispatchRate / deleteSubscriptionDispatchRate methods to pure async.

Documentation

  • no-need-doc

@gaoyanliang
Copy link
Contributor Author

@shibd @Technoboy- @mattisonchao PTAL

@gaoyanliang gaoyanliang changed the title Async subscription dispatch rate [improve][broker] Make some operation subscription dispatchRate methods in Namespaces async Jun 1, 2022
@gaoyanliang
Copy link
Contributor Author

Hi @Technoboy- Can you help trigger the ci ？

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

@gaoyanliang:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@shibd
Copy link
Member

shibd commented Jun 1, 2022

@gaoyanliang CI should be able to trigger automatically because you are not submitting pr for the first time.

When the ci job failed, you can use cmd/pulsarbot run-failure-checks to rerun these jobs(write in the comment area).

@gaoyanliang
Copy link
Contributor Author

@gaoyanliang CI should be able to trigger automatically because you are not submitting pr for the first time.

When the ci job failed, you can use cmd/pulsarbot run-failure-checks to rerun these jobs(write in the comment area).

ok, get it. Thanks

shibd
shibd approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@shibd shibd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java Outdated Show resolved Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java Outdated Show resolved Hide resolved
@Technoboy- Technoboy- added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/admin doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Jun 2, 2022
@Technoboy- Technoboy- added this to the 2.11.0 milestone Jun 2, 2022
@gaoyanliang
Copy link
Contributor Author

@Technoboy- @shibd fixed. PTAL

@gaoyanliang
Copy link
Contributor Author

/pulsarbot run-failure-checks

@gaoyanliang
Copy link
Contributor Author

@Technoboy- @mattisonchao ptal.

@gaoyanliang
Copy link
Contributor Author

/pulsarbot run-failure-checks

@gaoyanliang
Copy link
Contributor Author

/pulsarbot run-failure-checks

@gaoyanliang
Copy link
Contributor Author

/pulsarbot run-failure-checks

@gaoyanliang
Copy link
Contributor Author

@Technoboy- @mattisonchao All checks have passed. PTAL

@gaoyanliang
Copy link
Contributor Author

@Technoboy- @mattisonchao PTAL。

@gaoyanliang
Copy link
Contributor Author

Please give me some feedback if you have any questions about this task. @Technoboy- @mattisonchao @shibd

@gaoyanliang
Copy link
Contributor Author

/pulsarbot run-failure-checks

@gaoyanliang gaoyanliang force-pushed the async-subscription-dispatch-rate branch from 6648f16 to 2c9ff46 Compare June 13, 2022 02:14
@gaoyanliang
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@gaoyanliang
Copy link
Contributor Author

/pulsarbot run-failure-checks

@gaoyanliang
Copy link
Contributor Author

/pulsarbot run-failure-checks

@gaoyanliang
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@gaoyanliang
Copy link
Contributor Author

/pulsarbot run-failure-checks

@Technoboy- Technoboy- merged commit 00f98a4 into apache:master Jun 17, 2022
@gaozhangmin gaozhangmin mentioned this pull request Jul 1, 2022
Closed
26 tasks
@sijie sijie mentioned this pull request Aug 1, 2022
Open
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@RobertIndie RobertIndie RobertIndie approved these changes

@Demogorgon314 Demogorgon314 Demogorgon314 approved these changes

@shibd shibd shibd approved these changes

@mattisonchao mattisonchao mattisonchao approved these changes

Assignees

@gaoyanliang gaoyanliang

Labels
area/admin doc-not-needed Your PR changes do not impact docs type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gaoyanliang @shibd @Technoboy- @RobertIndie @Demogorgon314 @mattisonchao