Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][broker] Add dynamic configuration for UniformLoadShedder #16391

Merged
merged 1 commit into from Jul 29, 2022
Merged

[improve][broker] Add dynamic configuration for UniformLoadShedder #16391

merged 1 commit into from Jul 29, 2022

Conversation

lordcheng10
Copy link
Contributor

Motivation

Add dynamic configuration to UniformLoadShedder.

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jul 5, 2022
@lordcheng10 lordcheng10 changed the title Add dynamic configuration to UniformLoadShedder Add dynamic configuration for UniformLoadShedder Jul 5, 2022
@lordcheng10
Copy link
Contributor Author

@rdhabalia @shoothzj @hanbo1990 PTAL,thanks!

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

3 similar comments
@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10
Copy link
Contributor Author

@eolivelli @hangc0276 @codelipenghui PTAL,thanks!

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

aloyszhang
aloyszhang reviewed Jul 8, 2022
View reviewed changes
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
category = CATEGORY_LOAD_BALANCER,
doc = "In the UniformLoadShedder strategy, the minimum msg rate that triggers unload."
)
private int minUnloadMessage = 1000;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name should respect the description in doc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. PTAL,thanks! @aloyszhang

aloyszhang
aloyszhang reviewed Jul 8, 2022
View reviewed changes
Copy link
Contributor

@aloyszhang aloyszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

descriptions in doc should keep consistent with the field name

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10 lordcheng10 force-pushed the Dynamic_configuration_UniformLoadShedder branch from 7a1c064 to 5033d65 Compare July 12, 2022 10:12
@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

2 similar comments
@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

eolivelli
eolivelli approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

5 similar comments
@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10 lordcheng10 force-pushed the Dynamic_configuration_UniformLoadShedder branch from 5033d65 to d4cc670 Compare July 17, 2022 02:16
@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

4 similar comments
@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

6 similar comments
@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10 lordcheng10 force-pushed the Dynamic_configuration_UniformLoadShedder branch from eec19b9 to aa72dd7 Compare July 28, 2022 01:58
@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

5 similar comments
@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10 lordcheng10 force-pushed the Dynamic_configuration_UniformLoadShedder branch from aa72dd7 to 9cae319 Compare July 28, 2022 14:01
@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10
Copy link
Contributor Author

@Technoboy- @codelipenghui PTAL,thanks!

@Technoboy- Technoboy- added this to the 2.11.0 milestone Jul 29, 2022
@Technoboy- Technoboy- added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/broker labels Jul 29, 2022
@Technoboy- Technoboy- changed the title Add dynamic configuration for UniformLoadShedder [improve][broker] Add dynamic configuration for UniformLoadShedder Jul 29, 2022
@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@codelipenghui codelipenghui merged commit 4d64e2e into apache:master Jul 29, 2022
Gleiphir2769 pushed a commit to Gleiphir2769/pulsar that referenced this pull request Aug 4, 2022
@lordcheng10 @Gleiphir2769
[improve][broker] Add dynamic configuration to UniformLoadShedder (ap…
860d93d 
…ache#16391)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@eolivelli eolivelli eolivelli approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@aloyszhang aloyszhang aloyszhang approved these changes

Assignees

@lordcheng10 lordcheng10

Labels
area/broker doc-not-needed Your PR changes do not impact docs type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lordcheng10 @Technoboy- @eolivelli @codelipenghui @aloyszhang