Bump prometheus client version from 0.15.0 to 0.16.0 #16591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljmarshall
approved these changes
Jul 14, 2022
|
@shoothzj Please provide a correct documentation label for your PR. |
github-actions
bot
added
doc-label-missing
doc-not-needed
nicoloboschi
approved these changes
Jul 14, 2022
|
/pulsarbot run-failure-checks |
shoothzj
added a commit
to apache/bookkeeper
that referenced
this pull request
Jul 16, 2022
### Motivation See https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md A COUNTER needs `metrics_name_total` or `metrics_name_created` This PR contains metric name broken changes. ### Modifications Rename counter's `_count` to `_total` ### metrics name broken changes - rename `FAILED_TO_RESOLVE_NETWORK_LOCATION_COUNTER` to `FAILED_TO_RESOLVE_NETWORK_LOCATION_TOTAL` - rename `ENSEMBLE_NOT_ADHERING_TO_PLACEMENT_POLICY_COUNT` to `ENSEMBLE_NOT_ADHERING_TO_PLACEMENT_POLICY_TOTAL` - rename `ACTIVE_ENTRY_LOG_COUNT` to `ACTIVE_ENTRY_LOG_TOTAL` - rename `MAJOR_COMPACTION_COUNT` to `MAJOR_COMPACTION_TOTAL` - rename `MINOR_COMPACTION_COUNT` to `MINOR_COMPACTION_TOTAL` - rename `ACTIVE_LEDGER_COUNT` to `ACTIVE_LEDGER_TOTAL` - rename `DELETED_LEDGER_COUNT` to `DELETED_LEDGER_TOTAL` - rename `JOURNAL_FORCE_WRITE_GROUPING_COUNT` to `JOURNAL_FORCE_WRITE_GROUPING_TOTAL` ### Also see - apache/pulsar#13785 - apache/pulsar#16591 - apache/pulsar#16610 - apache/pulsar#16611
4 tasks
BewareMyPower
added
release/2.8.4
release/2.10.2
release/2.9.4
release/2.11.1
and removed
release/2.11.1
labels
|
Hi @shoothzj |
Jason918
pushed a commit
that referenced
this pull request
Sep 2, 2022
### Motivation prometheus client 0.16.0 contains some approvements that we can benefit from. Thanks for @dave2wave @michaeljmarshall the reminder and pointing out. > [ENHANCEMENT] Reduce the number of core threads in HTTPServer from 5 to 1. The HTTPServer will still start up to 5 threads on demand if there are parallel requests, but it will use only 1 thread as long as requests are sequential (prometheus/client_java#786). [ENHANCEMENT] Optimize metric name sanitization: Replace the regular expression with a hard-coded optimized algorithm to improve performance (prometheus/client_java#777). Thanks @fwbrasil See https://github.com/prometheus/client_java/releases ### Modifications Bump prometheus client version from 0.15.0 to 0.16.0 ### Documentation Check the box below or label this PR directly. Need to update docs? - [x] `doc-not-needed` dependency updates, no need doc (cherry picked from commit 948000b)
1 task
|
This PR depends on #13785 which is an important behavior change. So drop the labels for old versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
prometheus client 0.16.0 contains some approvements that we can benefit from. Thanks for @dave2wave @michaeljmarshall the reminder and pointing out.
See https://github.com/prometheus/client_java/releases
Modifications
Bump prometheus client version from 0.15.0 to 0.16.0
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-not-neededdependency updates, no need doc