New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forget to update memory usage when invalid message #16835
Conversation
23203ef
to
7ee709f
Compare
pulsar-client/src/main/java/org/apache/pulsar/client/impl/BatchMessageContainerImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch.
7ee709f
to
615f679
Compare
615f679
to
d13dd57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
/pulsarbot run-failure-checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
@gaozhangmin Please take the final look. Thanks! |
来信已收到,我会尽快查阅,祝你生活愉快。
|
### Modifications release memory usage when invalid message. Only need to release memory usage here, no need to release semaphore. Both add testcases. coauthored by @pengxiangrui127. ### Verifying this change - add unit tests for this change ### Documentation Check the box below or label this PR directly. Need to update docs? - [x] `doc-not-needed` bug fix, no need doc
@shoothzj Could you please help cherry-pick this PR to branch-2.9? |
@shoothzj Please provide a correct documentation label for your PR. |
### Modifications release memory usage when invalid message. Only need to release memory usage here, no need to release semaphore. Both add testcases. coauthored by @pengxiangrui127. ### Verifying this change - add unit tests for this change ### Documentation Check the box below or label this PR directly. Need to update docs? - [x] `doc-not-needed` bug fix, no need doc (cherry picked from commit 57b008a)
@shoothzj Please provide a correct documentation label for your PR. |
### Modifications release memory usage when invalid message. Only need to release memory usage here, no need to release semaphore. Both add testcases. coauthored by @pengxiangrui127. ### Verifying this change - add unit tests for this change ### Documentation Check the box below or label this PR directly. Need to update docs? - [x] `doc-not-needed` bug fix, no need doc (cherry picked from commit 57b008a)
### Modifications release memory usage when invalid message. Only need to release memory usage here, no need to release semaphore. Both add testcases. coauthored by @pengxiangrui127. ### Verifying this change - add unit tests for this change ### Documentation Check the box below or label this PR directly. Need to update docs? - [x] `doc-not-needed` bug fix, no need doc (cherry picked from commit 57b008a) (cherry picked from commit 72af22c)
release memory usage when invalid message. Only need to release memory usage here, no need to release semaphore. Both add testcases. coauthored by @pengxiangrui127. - add unit tests for this change Check the box below or label this PR directly. Need to update docs? - [x] `doc-not-needed` bug fix, no need doc (cherry picked from commit 57b008a)
release memory usage when invalid message. Only need to release memory usage here, no need to release semaphore. Both add testcases. coauthored by @pengxiangrui127. - add unit tests for this change Check the box below or label this PR directly. Need to update docs? - [x] `doc-not-needed` bug fix, no need doc (cherry picked from commit 57b008a)
release memory usage when invalid message. Only need to release memory usage here, no need to release semaphore. Both add testcases. coauthored by @pengxiangrui127. - add unit tests for this change Check the box below or label this PR directly. Need to update docs? - [x] `doc-not-needed` bug fix, no need doc (cherry picked from commit 57b008a)
Modifications
release memory usage when invalid message.
Only need to release memory usage here, no need to release semaphore. Both add testcases.
coauthored by @pengxiangrui127.
Verifying this change
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-not-needed
bug fix, no need doc