[fix][flaky-test]ManagedCursorMetricsTest.testCursorReadWriteMetrics #17045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
approved these changes
Aug 11, 2022
| return managedCursor.getStats(); | ||
| } | ||
|
|
||
| @Test(timeOut = 2 * 1000) |
There was a problem hiding this comment.
We can just use the default timeout? Or any reason to set it to 2 seconds for this test? It might become flaky in the CI environment.
There was a problem hiding this comment.
Or any reason to set it to 2 seconds for this test?
no
We can just use the default timeout?
already change to default timeout.
codelipenghui
approved these changes
Aug 11, 2022
|
/pulsarbot rerun-failure-checks |
2 similar comments
|
/pulsarbot rerun-failure-checks |
|
/pulsarbot rerun-failure-checks |
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Aug 14, 2022
Technoboy-
pushed a commit
to merlimat/pulsar
that referenced
this pull request
Aug 16, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 16, 2022
…pache#17045) (cherry picked from commit e0ff3d7) (cherry picked from commit eece41b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16948
Master Issue: #16948
Motivation
This test is flaky because that BK has not been successfully written when the asset executed
pulsar/pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/ManagedCursorMetricsTest.java
Lines 244 to 248 in e5d5fbe
Modifications
Makes assert execute after BK written
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)