Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][CI] Remove "Cancel duplicate workflows" workflow #17490

Merged

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Sep 6, 2022

Motivation

  • there's no need for "CI - Cancel duplicate workflows" workflow anymore since GitHub Actions has built-in support
    for cancelling duplicate workflows and this is used in Pulsar CI workflows.

  • GitHub Actions announced support in 4/2021

Pulsar workflows contain

concurrency:
  group: ${{ github.workflow }}-${{ github.ref }}
  cancel-in-progress: true

It has also been added to all apache/pulsar maintenance branches to prevent issues where cherry-picking many commits causes the build queue to fill up:
https://lists.apache.org/thread/29qox3y9z38z2t4441jhlnv6x71kfhdn

Modifications

  • remove .github/workflows/ci-cancel-duplicate-workflows.yaml

  • doc-not-needed

@lhotari lhotari added this to the 2.12.0 milestone Sep 6, 2022
@lhotari lhotari self-assigned this Sep 6, 2022
Copy link
Contributor

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lhotari lhotari added the area/ci label Sep 6, 2022
@github-actions
Copy link

github-actions bot commented Sep 6, 2022

@lhotari Please provide a correct documentation label for your PR.
Instructions see Pulsar Documentation Label Guide.

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Sep 6, 2022
- there's no need for this anymore since GitHub Actions has built-in support
  for cancelling duplicate workflows and this is used in Pulsar CI workflows.
@Technoboy- Technoboy- force-pushed the lh-remove-cancel-duplicate-workflows branch from ede4dd9 to c56ad85 Compare September 8, 2022 02:33
@lhotari lhotari merged commit cbdf700 into apache:master Sep 8, 2022
nicoloboschi pushed a commit to nicoloboschi/pulsar that referenced this pull request Sep 8, 2022
)

- there's no need for this anymore since GitHub Actions has built-in support
  for cancelling duplicate workflows and this is used in Pulsar CI workflows.
nicoloboschi pushed a commit that referenced this pull request Sep 9, 2022
- there's no need for this anymore since GitHub Actions has built-in support
  for cancelling duplicate workflows and this is used in Pulsar CI workflows.

(cherry picked from commit cbdf700)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants