[fix][test] fix testEndTxnWhenCommittingOrAborting flaky test #18318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
congbobo184
added
area/transaction
type/flaky-tests
doc-not-needed
congbobo184
requested review from
Technoboy-,
eolivelli,
codelipenghui,
gaoran10,
liangyepianzhou and
mattisonchao
labuladong
reviewed
Nov 3, 2022
Comment on lines
-346
to
-360
| if (this.interceptor != null) { | ||
| this.interceptor.txnEnded(txnID.toString(), TxnAction.ABORT_VALUE); | ||
| } |
There was a problem hiding this comment.
Why do we need to delete this part?
There was a problem hiding this comment.
If end transaction throws an exception, it doesn't mean the transaction has been ended, so we don't need to record it as aborted
There was a problem hiding this comment.
Maybe the title should no longer be “fix test“?
There was a problem hiding this comment.
Agree with @poorbarcode. Is this change related to this flaky test? If not, a new PR to delete it may be better.
Technoboy-
changed the title
poorbarcode
approved these changes
Nov 4, 2022
Comment on lines
-346
to
-360
| if (this.interceptor != null) { | ||
| this.interceptor.txnEnded(txnID.toString(), TxnAction.ABORT_VALUE); | ||
| } |
There was a problem hiding this comment.
Maybe the title should no longer be “fix test“?
|
@poorbarcode mainly to fix the flaky test, this is just to remove the wrong logic |
|
The pr had no activity for 30 days, mark with Stale label. |
|
new flaky-test case: |
2 tasks
…nCommittingOrAborting # Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarCommandSenderImpl.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18318
issue: https://github.com/apache/pulsar/actions/runs/3383985489/jobs/5620564078
Motivation
Transaction op count update after the write response, so we need to wait for the change to succeed
https://github.com/congbobo184/pulsar/blob/2b441bd2ab4b71d5bc182f85c62fbea633c4ce4b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarCommandSenderImpl.java#L314-L317
https://github.com/congbobo184/pulsar/blob/2b441bd2ab4b71d5bc182f85c62fbea633c4ce4b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarCommandSenderImpl.java#L334-L337
Modifications
wait count changed
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository:
congbobo184#7