Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][test] Add test brokerReachThreshold for ThresholdShedderTest #18664

Merged
merged 1 commit into from Nov 29, 2022

Conversation

Technoboy-
Copy link
Contributor

Motivation

More details are here #18598, so add this test to avoid regression.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@Technoboy- Technoboy- self-assigned this Nov 29, 2022
@Technoboy- Technoboy- added this to the 2.12.0 milestone Nov 29, 2022
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 29, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2022

Codecov Report

Merging #18664 (b50f4eb) into master (cee697b) will increase coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18664      +/-   ##
============================================
+ Coverage     47.06%   47.39%   +0.32%     
- Complexity     8956    10491    +1535     
============================================
  Files           592      698     +106     
  Lines         56313    68062   +11749     
  Branches       5844     7276    +1432     
============================================
+ Hits          26503    32255    +5752     
- Misses        26946    32208    +5262     
- Partials       2864     3599     +735     
Flag Coverage Δ
unittests 47.39% <ø> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...er/metadata/v2/TransactionBufferSnapshotIndex.java 0.00% <0.00%> (-77.78%) ⬇️
.../metadata/v2/TransactionBufferSnapshotSegment.java 0.00% <0.00%> (-75.00%) ⬇️
...he/pulsar/broker/service/PrecisPublishLimiter.java 0.00% <0.00%> (-73.98%) ⬇️
.../metadata/v2/TransactionBufferSnapshotIndexes.java 0.00% <0.00%> (-71.43%) ⬇️
...roker/service/schema/SchemaCompatibilityCheck.java 6.25% <0.00%> (-56.25%) ⬇️
...rvice/schema/ProtobufSchemaCompatibilityCheck.java 0.00% <0.00%> (-50.00%) ⬇️
...n/java/org/apache/pulsar/PulsarVersionStarter.java 0.00% <0.00%> (-42.31%) ⬇️
...oker/transaction/buffer/metadata/v2/TxnIDData.java 0.00% <0.00%> (-20.00%) ⬇️
...r/service/schema/JsonSchemaCompatibilityCheck.java 5.40% <0.00%> (-16.22%) ⬇️
...ransaction/buffer/impl/TopicTransactionBuffer.java 58.13% <0.00%> (-15.99%) ⬇️
... and 171 more

@Technoboy- Technoboy- changed the title [improve][test] Add test brokerReachThreshold for ThresholdShedderTest [improve][test] Add test brokerReachThreshold for ThresholdShedderTest Nov 29, 2022
@Technoboy- Technoboy- merged commit 58ad3d0 into apache:master Nov 29, 2022
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Dec 9, 2022
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Jan 10, 2023
@Technoboy- Technoboy- deleted the add-threshold-shedder-test branch September 14, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants