Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][sql] Fix presto license issue #18934

Closed
wants to merge 2 commits into from

Conversation

Technoboy-
Copy link
Contributor

@Technoboy- Technoboy- commented Dec 15, 2022

Motivation

pulsar git:(fix-license-header-1) ✗ src/check-binary-license.sh distribution/server/target/apache-pulsar-2.12.0-SNAPSHOT-bin.tar.gz
netty-transport-native-epoll-4.1.86.Final.jar unaccounted for in trino/LICENSE
listenablefuture-9999.0-empty-to-avoid-conflict-with-guava.jar mentioned in trino/LICENSE, but not bundled
failsafe-2.4.4.jar mentioned in trino/LICENSE, but not bundled
jersey-entity-filtering-2.34.jar mentioned in trino/LICENSE, but not bundled
jersey-media-json-jackson-2.34.jar mentioned in trino/LICENSE, but not bundled
jersey-media-multipart-2.34.jar mentioned in trino/LICENSE, but not bundled

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@Technoboy- Technoboy- added this to the 2.12.0 milestone Dec 15, 2022
@Technoboy- Technoboy- self-assigned this Dec 15, 2022
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2022

Codecov Report

Merging #18934 (8395046) into master (050b310) will decrease coverage by 1.68%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18934      +/-   ##
============================================
- Coverage     47.35%   45.66%   -1.69%     
- Complexity     9384    10009     +625     
============================================
  Files           623      677      +54     
  Lines         59104    66612    +7508     
  Branches       6146     7138     +992     
============================================
+ Hits          27987    30418    +2431     
- Misses        28100    32750    +4650     
- Partials       3017     3444     +427     
Flag Coverage Δ
unittests 45.66% <33.33%> (-1.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...va/org/apache/pulsar/broker/service/ServerCnx.java 48.11% <0.00%> (-0.43%) ⬇️
.../pulsar/broker/service/persistent/SystemTopic.java 92.30% <100.00%> (+0.64%) ⬆️
...rvice/schema/KeyValueSchemaCompatibilityCheck.java 21.62% <0.00%> (-45.95%) ⬇️
.../apache/pulsar/broker/loadbalance/LoadManager.java 61.11% <0.00%> (-16.67%) ⬇️
...ersistentStickyKeyDispatcherMultipleConsumers.java 46.07% <0.00%> (-12.26%) ⬇️
...pulsar/broker/service/PulsarCommandSenderImpl.java 65.64% <0.00%> (-11.29%) ⬇️
...ker/loadbalance/impl/LeastLongTermMessageRate.java 84.44% <0.00%> (-8.89%) ⬇️
...ervice/persistent/MessageRedeliveryController.java 56.09% <0.00%> (-7.32%) ⬇️
...he/pulsar/client/impl/PartitionedProducerImpl.java 30.34% <0.00%> (-5.13%) ⬇️
.../service/SystemTopicBasedTopicPoliciesService.java 69.51% <0.00%> (-4.27%) ⬇️
... and 149 more

@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Jan 16, 2023
@Technoboy- Technoboy- closed this Jan 17, 2023
@Technoboy- Technoboy- deleted the fix-license-header-1 branch November 11, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants