[feat][broker][PIP-195]Implement Filter out all delayed messages and skip them when reading messages from bookies - part7 #19035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| void asyncReadEntries(int numberOfEntriesToRead, ReadEntriesCallback callback, Object ctx, | ||
| PositionImpl maxPosition); | ||
| PositionImpl maxPosition, Predicate<PositionImpl> skipCondition); |
There was a problem hiding this comment.
It's better to add a new method.
I mean, we'd better not change the existing API directly.
This class is annotated with
@InterfaceAudience.LimitedPrivate
@InterfaceStability.Stable
coderzc
force-pushed
the
cursor_read_filter
branch
5 times, most recently
from
1b042a0
to
3aefb59
Compare
coderzc
added
type/feature
| * @param ctx opaque context | ||
| * @param maxPosition max position can read | ||
| */ | ||
| void asyncReadEntriesWithSkip(int numberOfEntriesToRead, long maxSizeBytes, ReadEntriesCallback callback, |
There was a problem hiding this comment.
It's better to add a default implementation. Otherwise, we will break the user's existing implementations.
There was a problem hiding this comment.
Yes, I mean just add default
default void asyncReadEntriesWithSkip()
Comment on lines
79
to
81
| if (lastPosition == null || entriesCount != 0) { | ||
| lastPosition = (PositionImpl) returnedEntries.get(entriesCount - 1).getPosition(); | ||
| } |
There was a problem hiding this comment.
If the returnedEntries is empty and the lastPosition is null, we will get an exception.
There was a problem hiding this comment.
It seems to we can only judge entriesCount != 0
managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedCursorTest.java
Show resolved
Hide resolved
.../java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java
Outdated
Show resolved
Hide resolved
Comment on lines
2079
to
2084
| for (; entryId <= lastEntry; entryId++) { | ||
| if (opReadEntry.skipCondition.test(PositionImpl.get(ledger.getId(), entryId))) { | ||
| break; | ||
| } | ||
| lastValidEntry = entryId; | ||
| } |
There was a problem hiding this comment.
Maybe you can try to optimize with only one loop to find the first invalid entry range 😁
| @@ -57,13 +61,13 @@ public static OpReadEntry create(ManagedCursorImpl cursor, PositionImpl readPosi | |||
| maxPosition = PositionImpl.LATEST; | |||
| } | |||
| op.maxPosition = maxPosition; | |||
| op.skipCondition = skipCondition; | |||
There was a problem hiding this comment.
it looks like we forget to reset it when recycle this obj
| op.ctx = ctx; | ||
| op.nextReadPosition = PositionImpl.get(op.readPosition); | ||
| return op; | ||
| } | ||
|
|
||
| @Override | ||
| public void readEntriesComplete(List<Entry> returnedEntries, Object ctx) { | ||
| void internalReadEntriesComplete(List<Entry> returnedEntries, Object ctx, PositionImpl lastPosition) { |
There was a problem hiding this comment.
I'm not sure if it is good to extend this method because we defined a parameter named context.
There was a problem hiding this comment.
context already be opReadEntry.ctx passing
mattisonchao
approved these changes
Dec 29, 2022
Comment on lines
79
to
81
| if (lastPosition == null || entriesCount != 0) { | ||
| lastPosition = (PositionImpl) returnedEntries.get(entriesCount - 1).getPosition(); | ||
| } |
Codecov Report
@@ Coverage Diff @@
## master #19035 +/- ##
============================================
- Coverage 49.85% 45.79% -4.07%
- Complexity 8658 11061 +2403
============================================
Files 500 772 +272
Lines 54930 74360 +19430
Branches 5867 8009 +2142
============================================
+ Hits 27386 34053 +6667
- Misses 24464 36518 +12054
- Partials 3080 3789 +709
Flags with carried forward coverage won't be shown. Click here to find out more.
|
coderzc
force-pushed
the
cursor_read_filter
branch
2 times, most recently
from
4197fb6
to
dc17954
Compare
codelipenghui
approved these changes
Dec 29, 2022
|
/pulsarbot run-failure-checks |
I noticed this test failed multiple times. Maybe related to the changes of this PR. |
coderzc
force-pushed
the
cursor_read_filter
branch
2 times, most recently
from
b49f41f
to
c57f05a
Compare
coderzc
force-pushed
the
cursor_read_filter
branch
from
c57f05a
to
fadff0b
Compare
5 tasks
15 tasks
4 tasks
15 tasks
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP: #16763
Motivation
#16763
Modifications
Implement Filter out all delayed messages and skip them when reading messages from bookies.
The logical changes are mainly in
ManagedLedgerImplandOpReadEntry.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: