[feat][admin] PIP-219 Part-1 Add admin API for trimming topic #19094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
315157973
requested review from
Technoboy-,
eolivelli,
gaozhangmin and
codelipenghui
gaoran10
reviewed
Dec 29, 2022
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java
Outdated
Show resolved
Hide resolved
gaoran10
reviewed
Dec 29, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
poorbarcode
reviewed
Dec 29, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
Technoboy-
reviewed
Jan 9, 2023
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #19094 +/- ##
============================================
- Coverage 47.11% 37.19% -9.92%
+ Complexity 10595 1987 -8608
============================================
Files 710 209 -501
Lines 69423 14450 -54973
Branches 7449 1577 -5872
============================================
- Hits 32709 5375 -27334
+ Misses 33037 8491 -24546
+ Partials 3677 584 -3093
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/TopicOperation.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java
Outdated
Show resolved
Hide resolved
# Conflicts: # pulsar-client-tools-test/src/test/java/org/apache/pulsar/admin/cli/PulsarAdminToolTest.java
|
@codelipenghui PTAL |
codelipenghui
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP: #18128
Motivation
In PIP-219, we want to support full scan and trim ledger.
First, we need to expose a trimTopic API so that the Leader Broker can clean up the corresponding zombie Ledger
Modifications
Add admin API for trimming topic
Verifying this change
315157973#4
Does this pull request potentially affect one of the following parts:
Documentation
doc-not-neededMatching PR in forked repository
315157973#4