Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][doc] Remove lombok plugin and define FunctionRecordBuilder explicitly #19202

Merged
merged 1 commit into from Jan 12, 2023

Conversation

tisonkun
Copy link
Member

@tisonkun tisonkun commented Jan 12, 2023

Verified locally with:

mvn -pl pulsar-client-api javadoc:javadoc 
mvn -pl pulsar-client-admin-api javadoc:javadoc
cd ./pulsar-functions 
mvn -pl api-java javadoc:javadoc

... results:

➜  pulsar git:(fix-javadoc) ls pulsar-client-api/target/site/apidocs
allclasses-index.html   jquery-ui.overrides.css resources
allpackages-index.html  legal                   script-dir
constant-values.html    member-search-index.js  script.js
deprecated-list.html    module-search-index.js  search.js
element-list            org                     serialized-form.html
help-doc.html           overview-summary.html   stylesheet.css
index-all.html          overview-tree.html      tag-search-index.js
index.html              package-search-index.js type-search-index.js
➜  pulsar git:(fix-javadoc) ls pulsar-client-admin-api/target/site/apidocs 
allclasses-index.html   jquery-ui.overrides.css resources
allpackages-index.html  legal                   script-dir
constant-values.html    member-search-index.js  script.js
deprecated-list.html    module-search-index.js  search.js
element-list            org                     serialized-form.html
help-doc.html           overview-summary.html   stylesheet.css
index-all.html          overview-tree.html      tag-search-index.js
index.html              package-search-index.js type-search-index.js
➜  pulsar git:(fix-javadoc) ls pulsar-functions/api-java/target/site/apidocs 
allclasses-index.html   legal                   script-dir
allpackages-index.html  member-search-index.js  script.js
deprecated-list.html    module-search-index.js  search.js
element-list            org                     stylesheet.css
help-doc.html           overview-summary.html   tag-search-index.js
index-all.html          overview-tree.html      type-search-index.js
index.html              package-search-index.js
jquery-ui.overrides.css resources
➜  pulsar git:(fix-javadoc) 

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

…icitly

Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun self-assigned this Jan 12, 2023
@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Jan 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2023

Codecov Report

Merging #19202 (1780e84) into master (4b0dc9a) will decrease coverage by 7.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #19202      +/-   ##
============================================
- Coverage     48.96%   41.84%   -7.13%     
+ Complexity     7300     2433    -4867     
============================================
  Files           424      235     -189     
  Lines         45473    16701   -28772     
  Branches       4672     1822    -2850     
============================================
- Hits          22268     6989   -15279     
+ Misses        20698     8959   -11739     
+ Partials       2507      753    -1754     
Flag Coverage Δ
unittests 41.84% <ø> (-7.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rcegroup/ResourceGroupNamespaceConfigListener.java
...e/pulsar/broker/service/EntryBatchIndexesAcks.java
...ce/ConsistentHashingStickyKeyConsumerSelector.java
...ker/service/plugin/EntryFilterWithClassLoader.java
...ker/loadbalance/impl/SimpleLoadCalculatorImpl.java
...ransactionBufferSnapshotBaseSystemTopicClient.java
...ache/pulsar/broker/loadbalance/ServiceRequest.java
...roker/admin/impl/OffloaderObjectsScannerUtils.java
...er/validator/TransactionBatchedWriteValidator.java
...oadbalance/extensions/data/TopBundlesLoadData.java
... and 597 more

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting!

+1

@tisonkun
Copy link
Member Author

delombok should help, but then we should move the related class to src/main/lombok and it's the same level of change as define explicitly. I choose a way more understandable for me to follow.

@Technoboy- Technoboy- merged commit d7f8f56 into apache:master Jan 12, 2023
@Technoboy- Technoboy- added this to the 3.0.0 milestone Feb 8, 2023
@tisonkun tisonkun deleted the fix-javadoc branch April 1, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/branch-2.11 doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. ready-to-test release/2.11.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants