[improve][broker] Follow up #19230 to tighten the validation scope #19234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks to @yuruguo. Could you help to review it? |
Codecov Report
@@ Coverage Diff @@
## master #19234 +/- ##
============================================
- Coverage 48.17% 47.14% -1.04%
- Complexity 9695 10697 +1002
============================================
Files 633 713 +80
Lines 59922 69729 +9807
Branches 6251 7498 +1247
============================================
+ Hits 28870 32874 +4004
- Misses 27947 33169 +5222
- Partials 3105 3686 +581
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
approved these changes
Jan 15, 2023
mattisonchao
added
release/2.11.1
release/2.9.5
release/2.10.4
cherry-picked/branch-2.9
mattisonchao
added a commit
that referenced
this pull request
Jan 16, 2023
…19234) ### Motivation This PR is following up #19230 As @yuruguo mentioned #19230 (comment), we can tighten the validation scope. I've checked the logic and found we have no way to create the partition topic with the `-partition-{index}` template. So we can righten the validation scope. I will keep working on the partition topic section and try to clarify the concept and logic. Plus, ensuring compatibility. ### Modifications - tighten the validation scope (cherry picked from commit 246c270)
mattisonchao
added a commit
that referenced
this pull request
Jan 17, 2023
…19234) ### Motivation This PR is following up #19230 As @yuruguo mentioned #19230 (comment), we can tighten the validation scope. I've checked the logic and found we have no way to create the partition topic with the `-partition-{index}` template. So we can righten the validation scope. I will keep working on the partition topic section and try to clarify the concept and logic. Plus, ensuring compatibility. ### Modifications - tighten the validation scope (cherry picked from commit 246c270)
4 tasks
liangyepianzhou
pushed a commit
that referenced
this pull request
Feb 25, 2023
…19234) This PR is following up #19230 As @yuruguo mentioned #19230 (comment), we can tighten the validation scope. I've checked the logic and found we have no way to create the partition topic with the `-partition-{index}` template. So we can righten the validation scope. I will keep working on the partition topic section and try to clarify the concept and logic. Plus, ensuring compatibility. - tighten the validation scope (cherry picked from commit 246c270)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 28, 2023
…ope (apache#19234) This PR is following up apache#19230 As @yuruguo mentioned apache#19230 (comment), we can tighten the validation scope. I've checked the logic and found we have no way to create the partition topic with the `-partition-{index}` template. So we can righten the validation scope. I will keep working on the partition topic section and try to clarify the concept and logic. Plus, ensuring compatibility. - tighten the validation scope (cherry picked from commit 246c270) (cherry picked from commit 2e3e9de)
|
Cherry-picked by #19839 |
mattisonchao
added a commit
that referenced
this pull request
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is following up #19230
As @yuruguo mentioned #19230 (comment), we can tighten the validation scope.
I've checked the logic and found we have no way to create the partition topic with the
-partition-{index}template. So we can righten the validation scope.I will keep working on the partition topic section and try to clarify the concept and logic. Plus, ensuring compatibility.
Modifications
Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-complete