[fix][broker] fix Update contains no change error when use --update-auth-data flag to update function/sink/source

[labuladong]

Fixes #19375

Modifications

When --update-auth-data is set to true, always update the data, even if the config is identical.

The key fix is changing

if (existingFunctionConfig.equals(mergedConfig) && isBlank(functionPkgUrl) && uploadedInputStream == null) {
            throw new RestException(Response.Status.BAD_REQUEST, "Update contains no change");
}

to

if (existingFunctionConfig.equals(mergedConfig) && isBlank(functionPkgUrl) && uploadedInputStream == null
                && (updateOptions == null || !updateOptions.isUpdateAuthData())) {
            throw new RestException(Response.Status.BAD_REQUEST, "Update contains no change");
}

For both function, source and sink.

Other modifications are test cases.

Verifying this change

• Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The threading model
• The binary protocol
• The REST endpoints
• The admin CLI options
• The metrics
• Anything that affects deployment

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository: labuladong#21

[github-actions]

The pr had no activity for 30 days, mark with Stale label.

[tisonkun]

LGTM. Thanks for your contribution!

[eolivelli]

+1

[tisonkun]

Merging...