[fix][fn] Make KubernetesRuntime translate characters in function tenant, namespace, and name during function removal to avoid label errors

[csthomas1]

Make KubernetesRuntime translate tenant, namespace, and function name characters that are not allowed within Kubernetes labels as part of function removal.

Fixes #19583

Motivation

See linked issue ticket.

Modifications

Updated KubernetesRuntime.deleteStatefulSet() to pass function tenant, namespace, and name values through the pre-existing getLabels() function to replace disallowed characters.

Verifying this change

• Make sure that the change passes the CI checks.

Adds the following test cases:

• KubernetesRuntimeTest:
  • testDeleteStatefulSetWithTranslatedKubernetesLabelChars(): Verifies that characters not supported by Kubernetes naming requirements are translated to acceptable forms

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The threading model
• The binary protocol
• The REST endpoints
• The admin CLI options
• The metrics
• Anything that affects deployment

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository: (csthomas1#1)

(All tests passed -- the Flaky tests failure occurs after execution of the tests themselves and appears to be due to a failed CodeCov upload attempt)

[github-actions]

The pr had no activity for 30 days, mark with Stale label.

[lhotari]

LGTM, thanks for the contribution!

[lhotari]

Closing and reopening to get a new build with a fresh merge commit for master branch in the build.

[nicoloboschi]

good catch! would you mind to add a test case?

[csthomas1]

Test added.

…

On Wed, Apr 5, 2023 at 3:24 AM Nicolò Boschi ***@***.***> wrote: ***@***.**** requested changes on this pull request. good catch! would you mind to add a test case? — Reply to this email directly, view it on GitHub <#19584 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQ5QVSJOBEJ2NX5I3JWJL4DW7UMZRANCNFSM6AAAAAAVDNP4DI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[lhotari]

Closing and re-opening to trigger a new CI build with changes from master branch.

[lhotari]

@csthomas1 would you mind merging changes from master (or rebasing the changes) and fixing the issues with current master?

Kubernetes client version was upgraded from 12.0.1 version to 18.0.0 version in 93fb4f8 . There are minor API changes which need to be addressed.

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:testCompile (default-testCompile) on project pulsar-functions-runtime: Compilation failure
Error:  /home/runner/work/pulsar/pulsar/pulsar-functions/runtime/src/test/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeTest.java:[1313,21] method readNamespacedStatefulSet in class io.kubernetes.client.openapi.apis.AppsV1Api cannot be applied to given types;
Error:    required: java.lang.String,java.lang.String,java.lang.String
Error:    found:    java.lang.String,java.lang.String,java.lang.Object,java.lang.Object,java.lang.Object
Error:    reason: actual and formal argument lists differ in length
Error:  -> [Help 1]

[codecov-commenter]

Codecov Report

Merging #19584 (83c5752) into master (51c2bb4) will increase coverage by 39.52%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             master   #19584       +/-   ##
=============================================
+ Coverage     33.50%   73.02%   +39.52%     
- Complexity    12053    31941    +19888     
=============================================
  Files          1613     1867      +254     
  Lines        126120   138591    +12471     
  Branches      13749    15222     +1473     
=============================================
+ Hits          42254   101210    +58956     
+ Misses        78332    29345    -48987     
- Partials       5534     8036     +2502     

Flag	Coverage Δ
inttests	24.25% <0.00%> (+0.08%)	⬆️
systests	25.09% <0.00%> (?)
unittests	72.27% <100.00%> (+40.35%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...unctions/runtime/kubernetes/KubernetesRuntime.java	49.16% <100.00%> (+49.16%)	⬆️

... and 1521 files with indirect coverage changes

[tisonkun]

Merging...

Thank you!