[fix][broker] Fix potential exception cause the policy service init fail. #19746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
added
release/2.11.1
release/2.10.5
release/2.9.6
area/broker
and removed
doc-not-needed
|
/pulsarbot run-failure-checks |
poorbarcode
approved these changes
Mar 8, 2023
|
/pulsarbot run-failure-checks |
2 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
mattisonchao
approved these changes
Mar 8, 2023
Demogorgon314
approved these changes
Mar 9, 2023
|
/pulsarbot run-failure-checks |
Technoboy-
added a commit
that referenced
this pull request
Mar 9, 2023
Technoboy-
added a commit
that referenced
this pull request
Mar 14, 2023
Technoboy-
added a commit
that referenced
this pull request
Mar 14, 2023
Technoboy-
added
cherry-picked/branch-2.9
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 29, 2023
…ail. (apache#19746) (cherry picked from commit 4449814)
touchkey
pushed a commit
to sajithsebastian/pulsar
that referenced
this pull request
May 24, 2023
touchkey
pushed a commit
to sajithsebastian/pulsar
that referenced
this pull request
May 26, 2023
…e init fail. (apache#19746)" This reverts commit f6cb0f8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We find that sometimes we can't get the topic policy all the time. After dumping the broker file, we find the namespace value in
policyCacheInitMapis false, but the reader was created successfully.I suspect that there may be some exceptions that occurs in the
refreshTopicPoliciesCache.Modifications
Move the
refreshTopicPoliciesCacheto thethenAcceptblock so we can catch any exceptions.Documentation
docdoc-requireddoc-not-neededdoc-complete