Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][meta] Follow up #19817, Fix race condition between ResourceLock update and invalidation #19844

Merged
merged 16 commits into from Mar 20, 2023
Merged

[fix][meta] Follow up #19817, Fix race condition between ResourceLock update and invalidation #19844

merged 16 commits into from Mar 20, 2023

Conversation

mattisonchao
Copy link
Member

@mattisonchao mattisonchao commented Mar 16, 2023 •
edited by merlimat

Motivation

This PR is following up the PR #19817. It includes three parts as follows:

  1. Fix the previous PR's incompletable future problem.
  2. Split revalidate into two methods to eliminate some flags.
  3. Add strict revalidation state check to avoid revalidating expired lock.

Modifications

  1. Fix the previous PR's incompletable future problem.
  2. Split revalidate into two methods to eliminate some flags.
  3. Add strict revalidation state check to avoid revalidating expired lock.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@mattisonchao mattisonchao self-assigned this Mar 16, 2023
@mattisonchao mattisonchao mentioned this pull request Mar 16, 2023
Merged
15 tasks
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 16, 2023
@mattisonchao mattisonchao added this to the 3.0.0 milestone Mar 16, 2023
@mattisonchao mattisonchao reopened this Mar 16, 2023
@mattisonchao
Copy link
Member Author

@merlimat @codelipenghui @Jason918 Please take a look. Thanks!

@mattisonchao mattisonchao reopened this Mar 17, 2023
@mattisonchao
Copy link
Member Author

The test has passed. And the original test updateValueWhenVersionIsOutOfSync will cover the future incomplete problem.

Could you please take a look?
/cc @merlimat @codelipenghui @hangc0276 @Jason918

merlimat
merlimat approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Jason918
Jason918 approved these changes Mar 18, 2023
View reviewed changes
Copy link
Contributor

@Jason918 Jason918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattisonchao mattisonchao reopened this Mar 19, 2023
@mattisonchao mattisonchao reopened this Mar 19, 2023
@mattisonchao mattisonchao reopened this Mar 20, 2023
@mattisonchao mattisonchao merged commit 2637bda into apache:master Mar 20, 2023
40 of 41 checks passed
@mattisonchao mattisonchao deleted the follow/19817 branch March 20, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@Jason918 Jason918 Jason918 approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@hangc0276 hangc0276 Awaiting requested review from hangc0276

Assignees

@mattisonchao mattisonchao

Labels
cherry-picked/branch-2.11 doc-not-needed Your PR changes do not impact docs ready-to-test release/2.11.1
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mattisonchao @merlimat @Jason918 @codelipenghui @Technoboy-