[fix] [admin] Make response code to 400 instead of 500 when delete topic fails due to enabled geo-replication #19879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pic fails due to enabled geo-replication
|
I think 422 is better. |
Good idea. Already changed the response code to |
| @@ -1106,7 +1106,9 @@ public void deleteTopic( | |||
| ex = new RestException(Response.Status.PRECONDITION_FAILED, | |||
| t.getMessage()); | |||
| } | |||
| if (isManagedLedgerNotFoundException(t)) { | |||
| if (t instanceof IllegalStateException){ | |||
There was a problem hiding this comment.
IMO, the common exception IllegalStateException is not good here. we can't identify what happened here. maybe we can improve it in the future?
mattisonchao
approved these changes
Mar 21, 2023
|
@poorbarcode Should we cherry-pick it to previous branches? |
coderzc
approved these changes
Mar 22, 2023
|
/pulsarbot rerun-failure-checks |
poorbarcode
added a commit
that referenced
this pull request
Mar 22, 2023
…pic fails due to enabled geo-replication (#19879) Motivation: As expected, If geo-replication is enabled, a topic cannot be deleted. However deleting that topic returns a 500, and no further info. Modifications: Make response code to 400 instead of 500 when delete topic fails due to enabled geo-replication (cherry picked from commit a903733)
poorbarcode
added a commit
that referenced
this pull request
Mar 22, 2023
…pic fails due to enabled geo-replication (#19879) Motivation: As expected, If geo-replication is enabled, a topic cannot be deleted. However deleting that topic returns a 500, and no further info. Modifications: Make response code to 400 instead of 500 when delete topic fails due to enabled geo-replication (cherry picked from commit a903733)
poorbarcode
added a commit
that referenced
this pull request
Mar 22, 2023
…pic fails due to enabled geo-replication (#19879) Motivation: As expected, If geo-replication is enabled, a topic cannot be deleted. However deleting that topic returns a 500, and no further info. Modifications: Make response code to 400 instead of 500 when delete topic fails due to enabled geo-replication (cherry picked from commit a903733)
poorbarcode
added
cherry-picked/branch-2.9
poorbarcode
added a commit
that referenced
this pull request
Mar 27, 2023
…pic fails due to enabled geo-replication (#19879) Motivation: As expected, If geo-replication is enabled, a topic cannot be deleted. However deleting that topic returns a 500, and no further info. Modifications: Make response code to 400 instead of 500 when delete topic fails due to enabled geo-replication (cherry picked from commit a903733)
poorbarcode
added a commit
that referenced
this pull request
Mar 27, 2023
…pic fails due to enabled geo-replication (#19879) Motivation: As expected, If geo-replication is enabled, a topic cannot be deleted. However deleting that topic returns a 500, and no further info. Modifications: Make response code to 400 instead of 500 when delete topic fails due to enabled geo-replication (cherry picked from commit a903733)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 29, 2023
…pic fails due to enabled geo-replication (apache#19879) Motivation: As expected, If geo-replication is enabled, a topic cannot be deleted. However deleting that topic returns a 500, and no further info. Modifications: Make response code to 400 instead of 500 when delete topic fails due to enabled geo-replication (cherry picked from commit a903733) (cherry picked from commit db6a59b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As expected, If geo-replication is enabled, a topic cannot be deleted. However deleting that topic returns a 500, and no further info.
In this case, we should give an error of 400 instead of 500.
Modifications
Make response code to 400 instead of 500 when delete topic fails due to enabled geo-replication
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: