New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][fn] Fix function update error #19895
Conversation
/pulsarbot rerun-failure-checks |
Without this fix, when users update a function with the new jar, py or go binary, they will get the following error:
|
/pulsarbot rerun-failure-checks |
2 similar comments
/pulsarbot rerun-failure-checks |
/pulsarbot rerun-failure-checks |
Codecov Report
@@ Coverage Diff @@
## master #19895 +/- ##
=============================================
+ Coverage 37.66% 72.88% +35.21%
- Complexity 345 31942 +31597
=============================================
Files 1691 1868 +177
Lines 129004 138548 +9544
Branches 14071 15246 +1175
=============================================
+ Hits 48592 100978 +52386
+ Misses 74114 29521 -44593
- Partials 6298 8049 +1751
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The pr had no activity for 30 days, mark with Stale label. |
aff1693
to
efe0969
Compare
/pulsarbot rerun-failure-checks |
@nlu90 Do we need to cherry-pick to other branches for this patch ? |
Fixes #19721
Master Issue: #xyz
PIP: #xyz
Motivation
functions are failed to update when
--py|--go|--jar
is specifiedModifications
add 1 to functions' version when uploading package while updating functions
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: jiangpengcheng#8