Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][fn] Make pulsar-admin support update py/go with package url #19897

Merged

Conversation

jiangpengcheng
Copy link
Contributor

Fixes #18966

Master Issue: #xyz

PIP: #xyz

Motivation

pulsar-admin functions update doesn't support package URL for python and golang

Modifications

Fix

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

  • This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: jiangpengcheng#9

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 22, 2023
@jiangpengcheng
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@flowchartsman
Copy link
Contributor

If we could backport this to at least 2.10 when it lands, you would make my year.

@nlu90
Copy link
Member

nlu90 commented Mar 27, 2023

@codelipenghui Can we backport this fix to 2.10?

@jiangpengcheng
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

1 similar comment
@jiangpengcheng
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link

Codecov Report

Merging #19897 (415635f) into master (1e44ba1) will increase coverage by 37.64%.
The diff coverage is 31.57%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #19897       +/-   ##
=============================================
+ Coverage     24.42%   62.06%   +37.64%     
- Complexity      291     3507     +3216     
=============================================
  Files          1603     1859      +256     
  Lines        124343   136741    +12398     
  Branches      13571    15033     +1462     
=============================================
+ Hits          30369    84875    +54506     
+ Misses        89490    44083    -45407     
- Partials       4484     7783     +3299     
Flag Coverage Δ
inttests 24.49% <22.10%> (+0.07%) ⬆️
systests 25.21% <7.36%> (?)
unittests 59.41% <31.57%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ker/loadbalance/extensions/models/TopKBundles.java 0.00% <0.00%> (ø)
...nsions/policies/AntiAffinityGroupPolicyHelper.java 0.00% <0.00%> (ø)
...extensions/reporter/TopBundleLoadDataReporter.java 0.00% <0.00%> (ø)
...dbalance/extensions/scheduler/TransferShedder.java 0.00% <0.00%> (ø)
...java/org/apache/pulsar/admin/cli/CmdFunctions.java 46.63% <0.00%> (+46.63%) ⬆️
...java/org/apache/pulsar/common/util/FutureUtil.java 79.62% <61.53%> (+49.10%) ⬆️
...ar/metadata/coordination/impl/LockManagerImpl.java 89.47% <71.42%> (+31.57%) ⬆️
...metadata/coordination/impl/LeaderElectionImpl.java 69.23% <75.00%> (+16.32%) ⬆️
.../apache/bookkeeper/mledger/impl/MetaStoreImpl.java 84.45% <100.00%> (+42.72%) ⬆️
...org/apache/pulsar/broker/ServiceConfiguration.java 98.74% <100.00%> (+0.84%) ⬆️

... and 1386 files with indirect coverage changes

@jiangpengcheng
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

1 similar comment
@jiangpengcheng
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@michaeljmarshall
Copy link
Member

This is a pretty clear bug, so I cherry picked it to several release branches.

michaeljmarshall pushed a commit to datastax/pulsar that referenced this pull request May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Cannot update functions with Package URL
7 participants