New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][build] Client modules should be built with Java 8 #19991
Conversation
Signed-off-by: tison <wander4096@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The broker modules should be compiled for jdk17
I agree that client must stay on 8.
Hi @lhotari & @eolivelli! The changeset for updating the broker compiler version is for profile |
…se blank for profile integration-test-java8 Signed-off-by: tison <wander4096@gmail.com>
Updated. Please give another look. |
Signed-off-by: tison <wander4096@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #19991 +/- ##
============================================
- Coverage 72.89% 72.82% -0.08%
+ Complexity 31619 31592 -27
============================================
Files 1861 1861
Lines 137356 137362 +6
Branches 15117 15118 +1
============================================
- Hits 100131 100039 -92
- Misses 29271 29366 +95
- Partials 7954 7957 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect
+1
Hi @Technoboy-! This can be a release blocker to 2.11.1. Since you're the RM for this release, I'd like to let you know this patch and ask if you can cherry-pick it to branch-2.11 and include it in 2.11.1. |
Thanks, cherry-picked to branch-2.11. |
This fixes #19982.
Motivation
Client modules are promised to be compatible with Java 8.
Modifications
Add
--releaase 8
for these two remaining client modules.Verifying this change
Locally tested.
Before:
After:
I don't know if we can add a CI step to ensure it.Add enforce plugin to prevent regressions.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: