New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] Save createIfMissing in TopicLoadingContext #19993
[improve][broker] Save createIfMissing in TopicLoadingContext #19993
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
@lifepuzzlefun Could you write a test? |
yeah, i'll add one later : - ) |
unit test added : - ) |
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceTest.java
Outdated
Show resolved
Hide resolved
928c168
to
cf14420
Compare
Codecov Report
@@ Coverage Diff @@
## master #19993 +/- ##
============================================
+ Coverage 72.91% 72.96% +0.05%
- Complexity 31916 31925 +9
============================================
Files 1867 1867
Lines 138558 138561 +3
Branches 15217 15219 +2
============================================
+ Hits 101026 101104 +78
+ Misses 29501 29435 -66
+ Partials 8031 8022 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
From my understanding, this is more like an improvement than a bug fix. We shouldn't put it into branch-3.0. So I remove the label |
…ssing in TopicLoadingContext (#19993)
…ssing in TopicLoadingContext (apache#19993) (cherry picked from commit 043ecd7)
Motivation
When topic load fail to acquire semaphore. a TopicLoadingContext is push into pendingLoadQueue, current TopicLoadingContext should also save the createIfMissing param in the TopicLoadingContext.
Modifications
add field in TopicLoadingContext.
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: