[fix][monitor] topic with double quote breaks the prometheus format #20230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricStreams.java
Show resolved
Hide resolved
This was referenced May 5, 2023
|
/pulsarbot rerun-failure-checks |
|
Weird topic name, it should be illegal after applying PIP #19239. |
mattisonchao
approved these changes
May 8, 2023
|
/pulsarbot rerun-failure-checks |
Codecov Report
@@ Coverage Diff @@
## master #20230 +/- ##
============================================
+ Coverage 34.48% 38.40% +3.91%
- Complexity 12537 13149 +612
============================================
Files 1614 1691 +77
Lines 126170 131348 +5178
Branches 13771 14519 +748
============================================
+ Hits 43509 50440 +6931
+ Misses 77053 74488 -2565
- Partials 5608 6420 +812
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nicoloboschi
added a commit
that referenced
this pull request
May 11, 2023
nicoloboschi
added a commit
that referenced
this pull request
May 11, 2023
nicoloboschi
added a commit
to datastax/pulsar
that referenced
this pull request
May 11, 2023
…pache#20230) (cherry picked from commit ea56197) (cherry picked from commit f94c8cb) (cherry picked from commit d8bf38e)
Merged
5 tasks
|
As discussed on the mailing list https://lists.apache.org/thread/w4jzk27qhtosgsz7l9bmhf1t7o9mxjhp, there is no plan to release 2.9.6, so I am going to remove the release/2.9.6 label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If you create a topic with the double quote in the name (e.g.
public/default/"mytopic) then there are some metrics that are generated in a broken format.This leads to errors in the grafana dashboards.
Modifications
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-complete