Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][build] Upgrade maven surefire plugin and other build/test plugins/libs including TestNG version #20270

Merged
merged 1 commit into from May 10, 2023
Merged

[improve][build] Upgrade maven surefire plugin and other build/test plugins/libs including TestNG version #20270

merged 1 commit into from May 10, 2023

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented May 9, 2023 •
edited

Motivation & Modifications

  • get rid of some warnings in maven 3.9.x
  • upgrade Maven surefire to a stable version
    • Pulsar was stuck on Maven surefire version 3.0.0-M3 for a very long time
  • upgrade other build/test related plugins
  • upgrade Gradle Enterprise maven extension to 1.17.1
  • upgrade TestNG version to 7.7.1

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: lhotari#146

@lhotari
[improve][build] Upgrade maven surefire plugin and other build/test p…
6ba7167 
…lugins including TestNG version

- get rid of some warnings in maven 3.9.x
- upgrade Maven surefire to a stable version
- upgrade other related plugins
- upgrade Gradle Enterprise maven extensions
- upgrade TestNG version
@github-actions
Copy link

github-actions bot commented May 9, 2023

@lhotari Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@lhotari lhotari mentioned this pull request May 9, 2023
Closed
@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels May 9, 2023
@lhotari
Copy link
Member Author

lhotari commented May 9, 2023

/pulsarbot rerun-failure-checks

eolivelli
eolivelli approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@codecov-commenter
Copy link

Codecov Report

Merging #20270 (6ba7167) into master (00f17e8) will increase coverage by 35.32%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #20270       +/-   ##
=============================================
+ Coverage     37.61%   72.93%   +35.32%     
- Complexity    12589    31956    +19367     
=============================================
  Files          1691     1868      +177     
  Lines        129028   138586     +9558     
  Branches      14066    15236     +1170     
=============================================
+ Hits          48530   101074    +52544     
+ Misses        74183    29471    -44712     
- Partials       6315     8041     +1726
Flag Coverage Δ
inttests 24.17% <ø> (ø)
systests 24.92% <ø> (+0.15%) ⬆️
unittests 72.20% <ø> (+39.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1427 files with indirect coverage changes

tisonkun
tisonkun approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lhotari lhotari merged commit 152b4a2 into apache:master May 10, 2023
50 of 52 checks passed
lhotari added a commit that referenced this pull request May 30, 2023
@lhotari
[improve][build] Upgrade maven surefire plugin and other build/test p…
5962136 
…lugins/libs including TestNG version (#20270)

(cherry picked from commit 152b4a2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eolivelli eolivelli eolivelli approved these changes

@tisonkun tisonkun tisonkun approved these changes

@michaeljmarshall michaeljmarshall michaeljmarshall approved these changes

@nicoloboschi nicoloboschi Awaiting requested review from nicoloboschi

Assignees
No one assigned
Labels
area/build cherry-picked/branch-3.0 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lhotari @codecov-commenter @eolivelli @tisonkun @michaeljmarshall @RobertIndie