New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][offload] use filesystem offloader with class not found error #20365
[fix][offload] use filesystem offloader with class not found error #20365
Conversation
@eolivelli PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the issued class is located at hadoop-hdfs-client
. Could you elaborate a bit why hadoop-client
is needed here?
2ce2a9a
to
3fb0e8f
Compare
@tisonkun Sorry for not timely reply. What you said is correct. After testing, simplifying the dependencies still works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
it would be great to setup an integration test one day.
I assume that you tested it manually
Is this problem also on Pulsar 3.0 ?
should we cherry-pick this PR to branch-3.0 ?
Codecov Report
@@ Coverage Diff @@
## master #20365 +/- ##
============================================
+ Coverage 73.00% 73.07% +0.07%
- Complexity 31962 31991 +29
============================================
Files 1867 1867
Lines 138661 138661
Branches 15235 15235
============================================
+ Hits 101227 101328 +101
+ Misses 29382 29301 -81
+ Partials 8052 8032 -20
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
yes. tested it manually and branch-3.0 has the same problem. |
Merging... cc @RobertIndie I guess we can include this patch for 3.0.x on 3.0.2 at the earliest? |
I see the mentioned issue #16955 with broker-2.10, so we need at least cherry-pick this to 2.10. |
apache#20365) (cherry picked from commit 56ce296) (cherry picked from commit a91874b)
Fixes #16955
Motivation
fix the problem about Failing to start standalone pulsar service with tiered storage due to class not found problem
The reason is the lack of dependencies for the
org.apache.hadoop.hdfs.DistributedFileSystem
class.Modifications
add DistributedFileSystem class dependency
hadoop-client
in pom.xmlVerifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: ethqunzhong#5