[fix][cli] Fulfill add-opens to function-localrunner also

[tisonkun]

This closes #20282.

Motivation

Fulfill add-opens to function-localrunner also.

This issue affects version >= 2.11.

Verifying this change

• Make sure that the change passes the CI checks and manually tested locally.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The threading model
• The binary protocol
• The REST endpoints
• The admin CLI options
• The metrics
• Anything that affects deployment

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository:

[tisonkun]

This is the effective change. Others are refactors during the debugging stage.

[codecov-commenter]

Codecov Report

Merging #20417 (34077e6) into master (aa3bfcd) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #20417      +/-   ##
============================================
- Coverage     72.90%   72.90%   -0.01%     
- Complexity    31864    31870       +6     
============================================
  Files          1864     1864              
  Lines        138416   138416              
  Branches      15188    15188              
============================================
- Hits         100919   100918       -1     
- Misses        29477    29479       +2     
+ Partials       8020     8019       -1     

Flag	Coverage Δ
inttests	24.16% <ø> (-0.01%)	⬇️
systests	25.04% <ø> (-0.02%)	⬇️
unittests	72.18% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 75 files with indirect coverage changes

[lifepuzzlefun]

@tisonkun thanks for this fix. and i saw more add-open options in pulsar start script. do we need them also ? see

pulsar/bin/pulsar

Lines 297 to 311 in aa3bfcd

	if [[ -z "$IS_JAVA_8" ]]; then
	# BookKeeper: enable posix_fadvise usage and DirectMemoryCRC32Digest (https://github.com/apache/bookkeeper/pull/3234)
	OPTS="$OPTS --add-opens java.base/java.io=ALL-UNNAMED --add-opens java.base/java.util.zip=ALL-UNNAMED"
	# Netty: enable java.nio.DirectByteBuffer
	# https://github.com/netty/netty/blob/4.1/common/src/main/java/io/netty/util/internal/PlatformDependent0.java
	# https://github.com/netty/netty/issues/12265
	OPTS="$OPTS --add-opens java.base/java.nio=ALL-UNNAMED --add-opens java.base/jdk.internal.misc=ALL-UNNAMED"
	# netty.DnsResolverUtil
	OPTS="$OPTS --add-opens java.base/sun.net=ALL-UNNAMED"
	# JvmDefaultGCMetricsLogger & MBeanStatsGenerator
	OPTS="$OPTS --add-opens java.management/sun.management=ALL-UNNAMED"
	# MBeanStatsGenerator
	OPTS="$OPTS --add-opens jdk.management/com.sun.management.internal=ALL-UNNAMED"
	# LinuxInfoUtils
	OPTS="$OPTS --add-opens java.base/jdk.internal.platform=ALL-UNNAMED"

[tisonkun]

@lifepuzzlefun I tend to add them on demand instead of pull in too much options. This is also how the upstream JDK's trend to restrict access.

That said, if we open unnecessary modules, it's more likely we introduce more dependency without explicit review.

[lifepuzzlefun]

@lifepuzzlefun I tend to add them on demand instead of pull in too much options. This is also how the upstream JDK's trend to restrict access.

That said, if we open unnecessary modules, it's more likely we introduce more dependency without explicit review.

yes, i agree with you.

[eolivelli]

please remove this change that seems unrelated

[eolivelli]

Overall I support the patch, but there is some change that seems unrelated

[tisonkun]

@eolivelli reverted

Resolved.