Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][io][branch-2.10] Close the kafka source connector if there is uncaught exception #20479

Merged
merged 1 commit into from Jun 6, 2023

Conversation

RobertIndie
Copy link
Member

Motivation

Cherry-pick #20424

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@RobertIndie RobertIndie self-assigned this Jun 2, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 2, 2023
@RobertIndie
Copy link
Member Author

I'm curious why the license check failed on branch-2.10 but success on the master branch.

@tisonkun
Copy link
Member

tisonkun commented Jun 5, 2023

I'm curious why the license check failed on branch-2.10 but success on the master branch.

Different feature releases can have a quite different dependency tree so it's normal.

@RobertIndie RobertIndie closed this Jun 5, 2023
@RobertIndie RobertIndie reopened this Jun 5, 2023
@RobertIndie
Copy link
Member Author

/pulsarbot run-failure-checks

Signed-off-by: Zike Yang <zike@apache.org>
@RobertIndie RobertIndie merged commit 49eaa30 into apache:branch-2.10 Jun 6, 2023
25 of 28 checks passed
@RobertIndie RobertIndie deleted the cr-20424-2-10 branch June 6, 2023 09:10
yaalsn pushed a commit to streamnative/pulsar-archived that referenced this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants