New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][test] Reduce flakiness of AdminApi2Test #20529
Conversation
/pulsarbot rerun-failure-checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Also this test class is very big, maybe it would be worth splitting it into smaller classes
- calling resetConfig method between test methods is the wrong solution - use unique tenants and namespaces to make it easier to track where the possibly conflicting topics were created, if the problems preserve
faf1d9a
to
81eb7d0
Compare
+1 |
Codecov Report
@@ Coverage Diff @@
## master #20529 +/- ##
============================================
- Coverage 72.93% 72.90% -0.04%
+ Complexity 31930 31820 -110
============================================
Files 1867 1867
Lines 138555 138554 -1
Branches 15218 15218
============================================
- Hits 101059 101015 -44
- Misses 29466 29522 +56
+ Partials 8030 8017 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
(cherry picked from commit 60dba5d)
Fixes #20376
Motivation
AdminApi2Test is extremely flaky and causes most builds to fail.
Modifications
Documentation
doc
doc-required
doc-not-needed
doc-complete