Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat][broker]PIP-255 Part-2: Make the partition assignment strategy pluggable #20537

Merged
merged 30 commits into from Jun 30, 2023

Conversation

xiaotongwang1
Copy link
Contributor

@xiaotongwang1 xiaotongwang1 commented Jun 8, 2023

PIP: #19806

Motivation

Make the partition assignment strategy pluggable

Modifications

broker find bundle api

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 8, 2023
@Technoboy- Technoboy- added this to the 3.1.0 milestone Jun 9, 2023
@315157973
Copy link
Contributor

@Technoboy- PLAL

Copy link
Contributor

@BewareMyPower BewareMyPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add line break at the end of file

@codecov-commenter
Copy link

Codecov Report

Merging #20537 (1a278e0) into master (0e60340) will increase coverage by 0.51%.
The diff coverage is 80.64%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #20537      +/-   ##
============================================
+ Coverage     72.60%   73.12%   +0.51%     
- Complexity    32018    32053      +35     
============================================
  Files          1855     1869      +14     
  Lines        138569   138783     +214     
  Branches      15250    15264      +14     
============================================
+ Hits         100605   101481     +876     
+ Misses        29945    29266     -679     
- Partials       8019     8036      +17     
Flag Coverage Δ
inttests 24.18% <70.96%> (+0.07%) ⬆️
systests 25.00% <70.96%> (?)
unittests 72.39% <80.64%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ar/common/naming/TopicBundleAssignmentFactory.java 66.66% <66.66%> (ø)
...org/apache/pulsar/broker/ServiceConfiguration.java 99.38% <100.00%> (+<0.01%) ⬆️
...n/naming/ConsistentHashingTopicBundleAssigner.java 100.00% <100.00%> (ø)
...e/pulsar/common/naming/NamespaceBundleFactory.java 80.87% <100.00%> (+4.07%) ⬆️
.../apache/pulsar/common/naming/NamespaceBundles.java 79.74% <100.00%> (-0.98%) ⬇️

... and 155 files with indirect coverage changes

@315157973 315157973 merged commit 2f0555c into apache:master Jun 30, 2023
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants