Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][meta] Adding the missed bookie id in the registration manager. #20641

Merged
merged 1 commit into from Jun 29, 2023
Merged

[fix][meta] Adding the missed bookie id in the registration manager. #20641

merged 1 commit into from Jun 29, 2023

Conversation

mattisonchao
Copy link
Member

Motivation

Adding the missed bookie id in the registration manager.

Modifications

  • Adding the missed bookie id in the registration manager.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@mattisonchao mattisonchao self-assigned this Jun 25, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 25, 2023
@mattisonchao mattisonchao added area/metadata and removed doc-not-needed Your PR changes do not impact docs labels Jun 25, 2023
@mattisonchao mattisonchao added this to the 3.1.0 milestone Jun 25, 2023
@mattisonchao mattisonchao reopened this Jun 25, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 25, 2023
@mattisonchao mattisonchao changed the title [fix][metadata] Adding the missed bookie id in the registration manager. [fix][meta] Adding the missed bookie id in the registration manager. Jun 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2023

Codecov Report

Merging #20641 (90f1da6) into master (43b3622) will increase coverage by 1.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #20641      +/-   ##
============================================
+ Coverage     72.05%   73.32%   +1.27%     
- Complexity    31718    32116     +398     
============================================
  Files          1855     1867      +12     
  Lines        138376   139288     +912     
  Branches      15198    15266      +68     
============================================
+ Hits          99703   102139    +2436     
+ Misses        30656    29162    -1494     
+ Partials       8017     7987      -30     
Flag Coverage Δ
inttests 24.60% <0.00%> (+0.50%) ⬆️
systests 25.05% <0.00%> (?)
unittests 72.61% <100.00%> (+0.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...metadata/bookkeeper/PulsarRegistrationManager.java 62.43% <100.00%> (ø)

... and 247 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants