Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][cli] Fix error messages in CmdNameSpaces and CmdTopics #20701

Merged
merged 1 commit into from Jul 4, 2023
Merged

[fix][cli] Fix error messages in CmdNameSpaces and CmdTopics #20701

merged 1 commit into from Jul 4, 2023

Conversation

JooHyukKim
Copy link
Contributor

Motivation

Fixes error messages CmdNameSpaces and CmdTopics that describe opposite of what really happens.

Modifications

Same as title.

Verifying this change

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jul 1, 2023
@Technoboy- Technoboy- added this to the 3.1.0 milestone Jul 3, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #20701 (fcaa60e) into master (c5237ea) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #20701      +/-   ##
============================================
- Coverage     73.13%   73.10%   -0.04%     
+ Complexity    32101    32089      -12     
============================================
  Files          1871     1871              
  Lines        138982   138982              
  Branches      15283    15283              
============================================
- Hits         101651   101599      -52     
- Misses        29280    29319      +39     
- Partials       8051     8064      +13     
Flag Coverage Δ
inttests 24.11% <0.00%> (-0.10%) ⬇️
systests 24.98% <0.00%> (-0.15%) ⬇️
unittests 72.37% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ava/org/apache/pulsar/admin/cli/CmdNamespaces.java 76.17% <0.00%> (ø)
...in/java/org/apache/pulsar/admin/cli/CmdTopics.java 78.94% <0.00%> (ø)

... and 77 files with indirect coverage changes

@tisonkun
Copy link
Member

tisonkun commented Jul 4, 2023

Merging...

Thank you!

@tisonkun tisonkun merged commit 886f535 into apache:master Jul 4, 2023
46 checks passed
@JooHyukKim JooHyukKim deleted the Fix-typo-on-cmd branch August 23, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants