[improve][offload] Support to configure more offload driver #20736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- ### Motivation In pulsar offload, we will check if the specified offload driver is supported. But our offload can extend by implement the offload interface. For more easier to specified the other offload name, we should provide a way to configure the offload dirver name. We are limit the offload driver name by a immutable list. Makeing it can accept more offload driver name by properties.
zymap
added
type/enhancement
|
@zymap Please add the following content to your PR description and select a checkbox: |
zymap
added
ready-to-test
and removed
doc-not-needed
hangc0276
reviewed
Jul 7, 2023
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/OffloadPoliciesImpl.java
Outdated
Show resolved
Hide resolved
hangc0276
approved these changes
Jul 10, 2023
Technoboy-
approved these changes
Jul 11, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Jul 24, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #xyz
Main Issue: #xyz
PIP: #xyz
Motivation
In pulsar offload, we will check if the specified offload driver is supported. But our offload can extend by implementing the offload interface. For easier to specify the other offload name, we should provide a way to configure the offload driver name. We are limiting the offload driver name by an immutable list. Making it can accept more offload driver names by properties.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: