[improve][offload] Create offload resources lazily #20775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- ### Motivation When create a topic, it will create the offload resources. The offload resources only used when the offload triggered. When the broker restarting, there have a lot of topics are loading. Create offload blobstore lazilyto avoid creating too much resources when the broker restarting.
zymap
added
type/enhancement
zymap
requested review from
merlimat,
hangc0276,
Technoboy-,
eolivelli,
codelipenghui and
mattisonchao
Codecov Report
@@ Coverage Diff @@
## master #20775 +/- ##
=============================================
+ Coverage 33.44% 73.15% +39.71%
- Complexity 12097 32142 +20045
=============================================
Files 1612 1866 +254
Lines 126568 139030 +12462
Branches 13824 15295 +1471
=============================================
+ Hits 42328 101707 +59379
+ Misses 78686 29273 -49413
- Partials 5554 8050 +2496
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
approved these changes
Jul 13, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Jul 24, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #xyz
Main Issue: #xyz
PIP: #xyz
Motivation
When creating a topic, it will create the offload resources. The offload resources are only used when the offload is triggered. When the broker restarts, there have a lot of topics loading.
Create offload blobstore lazily to avoid creating too many resources when the broker restarts.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: