Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][build] Upgrade PyYaml version to 6.0.1 #20831

Merged
merged 2 commits into from Jul 20, 2023
Merged

[fix][build] Upgrade PyYaml version to 6.0.1 #20831

merged 2 commits into from Jul 20, 2023

Conversation

yaalsn
Copy link
Contributor

@yaalsn yaalsn commented Jul 18, 2023

Motivation

See yaml/pyyaml#724 .

We need to upgrade pyyaml to 6.0.1 to resolve this issue .

[INFO] DOCKER> Step 21/30 : RUN pip3 install pyyaml==5.4.1
[INFO] DOCKER> 
[INFO] DOCKER> ---> Running in ef1c59ec2468
[INFO] DOCKER> Collecting pyyaml==5.4.1
[INFO] DOCKER> Downloading PyYAML-5.4.1.tar.gz (175 kB)
[INFO] DOCKER> ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 175.1/175.1 KB 4.4 MB/s eta 0:00:00
[INFO] DOCKER> 
[INFO] DOCKER> Installing build dependencies: started
[INFO] DOCKER> Installing build dependencies: finished with status 'done'
[INFO] DOCKER> Getting requirements to build wheel: started
[INFO] DOCKER> Getting requirements to build wheel: finished with status 'error'
[INFO] DOCKER> [91m  error: subprocess-exited-with-error
  
  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [43 lines of output]
      running egg_info
      Traceback (most recent call last):
        File "/usr/lib/python3/dist-packages/pip/_vendor/pep517/in_process/_in_process.py", line 363, in <module>
          main()
        File "/usr/lib/python3/dist-packages/pip/_vendor/pep517/in_process/_in_process.py", line 345, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
        File "/usr/lib/python3/dist-packages/pip/_vendor/pep517/in_process/_in_process.py", line 130, in get_requires_for_build_wheel
          return hook(config_settings)
        File "/usr/lib/python3/dist-packages/setuptools/build_meta.py", line 162, in get_requires_for_build_wheel
          return self._get_build_requires(
        File "/usr/lib/python3/dist-packages/setuptools/build_meta.py", line 143, in _get_build_requires
          self.run_setup()
        File "/usr/lib/python3/dist-packages/setuptools/build_meta.py", line 158, in run_setup
          exec(compile(code, __file__, 'exec'), locals())
        File "setup.py", line 271, in <module>
          setup(
        File "/usr/lib/python3/dist-packages/setuptools/__init__.py", line 153, in setup
          return distutils.core.setup(**attrs)
        File "/usr/lib/python3/dist-packages/setuptools/_distutils/core.py", line 148, in setup
          return run_commands(dist)
        File "/usr/lib/python3/dist-packages/setuptools/_distutils/core.py", line 163, in run_commands
          dist.run_commands()
        File "/usr/lib/python3/dist-packages/setuptools/_distutils/dist.py", line 967, in run_commands
          self.run_command(cmd)
        File "/usr/lib/python3/dist-packages/setuptools/_distutils/dist.py", line 986, in run_command
          cmd_obj.run()
        File "/usr/lib/python3/dist-packages/setuptools/command/egg_info.py", line 299, in run
          self.find_sources()
        File "/usr/lib/python3/dist-packages/setuptools/command/egg_info.py", line 306, in find_sources
          mm.run()
        File "/usr/lib/python3/dist-packages/setuptools/command/egg_info.py", line 541, in run
          self.add_defaults()
        File "/usr/lib/python3/dist-packages/setuptools/command/egg_info.py", line 578, in add_defaults
          sdist.add_defaults(self)
        File "/usr/lib/python3/dist-packages/setuptools/_distutils/command/sdist.py", line 228, in add_defaults
          self._add_defaults_ext()
        File "/usr/lib/python3/dist-packages/setuptools/_distutils/command/sdist.py", line 312, in _add_defaults_ext
          self.filelist.extend(build_ext.get_source_files())
        File "setup.py", line 201, in get_source_files
          self.cython_sources(ext.sources, ext)
        File "/usr/lib/python3/dist-packages/setuptools/_distutils/cmd.py", line 103, in __getattr__
          raise AttributeError(attr)
      AttributeError: cython_sources
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.

[INFO] DOCKER> [91merror: subprocess-exited-with-error

× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

[INFO] DOCKER> Removing intermediate container ef1c59ec2468
Error:  DOCKER> Unable to build image [apachepulsar/pulsar] : "The command '/bin/sh -c pip3 install pyyaml==5.4.1' returned a non-zero code: 1"  ["The command '/bin/sh -c pip3 install pyyaml==5.4.1' returned a non-zero code: 1" ]

Modifications

Dockerfile

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: https://github.com/yaalsn/pulsar/pull/2

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jul 18, 2023
@yaalsn
Copy link
Contributor Author

yaalsn commented Jul 18, 2023

@mattisonchao @Technoboy- PTAL

@yaalsn
Copy link
Contributor Author

yaalsn commented Jul 18, 2023

/pulsarbot rerun-failure-checks

@coderzc
Copy link
Member

coderzc commented Jul 19, 2023

/pulsarbot rerun-failure-checks

1 similar comment
@yaalsn
Copy link
Contributor Author

yaalsn commented Jul 19, 2023

/pulsarbot rerun-failure-checks

@coderzc
Copy link
Member

coderzc commented Jul 19, 2023

/pulsarbot rerun-failure-checks

@michaeljmarshall
Copy link
Member

Fixes #20839

@michaeljmarshall michaeljmarshall linked an issue Jul 20, 2023 that may be closed by this pull request
2 tasks
@Technoboy- Technoboy- merged commit f5553a2 into apache:master Jul 20, 2023
45 checks passed
@yaalsn
Copy link
Contributor Author

yaalsn commented Jul 20, 2023

@Technoboy- This PR should cherry-pick to branch-2.9, 2.10, 2.11 and 3.0.

@michaeljmarshall
Copy link
Member

@Technoboy- This PR should cherry-pick to branch-2.9, 2.10, 2.11 and 3.0.

The only consideration is whether any of those images rely on python 2.7. Pyyaml 6.0 dropped support for python 2.7.

@yaalsn
Copy link
Contributor Author

yaalsn commented Jul 20, 2023

I checked all the branch Dockerfile files, and they all install py3.

@dave2wave
Copy link
Member

The build for 2.10 works fine. The problem is more the use of Ubuntu 22.04 and the wheel for Pyyaml 5.4.1. It is not necessary to update 2.10 and 2.9 (which is EOL?)

@dave2wave
Copy link
Member

I've tested the master docker build with this PR and the trouble is solved

@michaeljmarshall
Copy link
Member

Perhaps 2.10 does not need it because it is using Ubuntu 20.04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] CI Blocker Build Pulsar docker image failure
7 participants