New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][build] Upgrade PyYaml version to 6.0.1 #20831
Conversation
@mattisonchao @Technoboy- PTAL |
/pulsarbot rerun-failure-checks |
/pulsarbot rerun-failure-checks |
1 similar comment
/pulsarbot rerun-failure-checks |
/pulsarbot rerun-failure-checks |
Fixes #20839 |
@Technoboy- This PR should cherry-pick to branch-2.9, 2.10, 2.11 and 3.0. |
The only consideration is whether any of those images rely on python 2.7. Pyyaml 6.0 dropped support for python 2.7. |
I checked all the branch Dockerfile files, and they all install py3. |
The build for 2.10 works fine. The problem is more the use of Ubuntu 22.04 and the wheel for Pyyaml 5.4.1. It is not necessary to update 2.10 and 2.9 (which is EOL?) |
I've tested the master docker build with this PR and the trouble is solved |
(cherry picked from commit f5553a2)
(cherry picked from commit f5553a2)
Perhaps 2.10 does not need it because it is using Ubuntu 20.04. |
Motivation
See yaml/pyyaml#724 .
We need to upgrade pyyaml to 6.0.1 to resolve this issue .
Modifications
Dockerfile
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: https://github.com/yaalsn/pulsar/pull/2