New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve] [broker] improve read entry error log for troubleshooting #21169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poorbarcode
requested review from
hangc0276,
BewareMyPower,
coderzc and
liangyepianzhou
September 12, 2023 07:11
liangyepianzhou
approved these changes
Sep 12, 2023
lifepuzzlefun
approved these changes
Sep 12, 2023
RobertIndie
approved these changes
Sep 12, 2023
Codecov Report
@@ Coverage Diff @@
## master #21169 +/- ##
=============================================
+ Coverage 36.84% 73.18% +36.34%
- Complexity 12179 32466 +20287
=============================================
Files 1698 1887 +189
Lines 130330 140064 +9734
Branches 14247 15427 +1180
=============================================
+ Hits 48016 102509 +54493
+ Misses 75966 29460 -46506
- Partials 6348 8095 +1747
Flags with carried forward coverage won't be shown. Click here to find out more.
|
5 tasks
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 15, 2024
…pache#21169) (cherry picked from commit 65706c6) (cherry picked from commit faee123)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 17, 2024
…pache#21169) (cherry picked from commit 65706c6) (cherry picked from commit faee123)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 19, 2024
…pache#21169) (cherry picked from commit 65706c6) (cherry picked from commit faee123)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 23, 2024
…pache#21169) (cherry picked from commit 65706c6) (cherry picked from commit faee123)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-2.10
cherry-picked/branch-2.11
cherry-picked/branch-3.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/2.10.6
release/2.11.3
release/3.0.2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is a log of error logs indicating that the broker tries to read a deleted ledger. Since there are a lot of subscriptions under this topic(durable and non-durable) and the ledger id already removed from the topic's ledgers list, we do not know what happened.
Modifications
If the read entry fails, add the cursor name to the error log.
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: x