New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] Fixed reset for AggregatedNamespaceStats #21225
Merged
codelipenghui
merged 2 commits into
apache:master
from
asafm:fix-missing-fields-in-reset-ns
Sep 24, 2023
Merged
[fix][broker] Fixed reset for AggregatedNamespaceStats #21225
codelipenghui
merged 2 commits into
apache:master
from
asafm:fix-missing-fields-in-reset-ns
Sep 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@asafm Please add the following content to your PR description and select a checkbox:
|
github-actions
bot
added
doc-not-needed
Your PR changes do not impact docs
and removed
doc-label-missing
labels
Sep 21, 2023
codelipenghui
added
release/3.0.2
release/2.11.3
release/2.10.6
release/3.1.1
type/bug
The PR fixed a bug or issue reported a bug
area/metrics
labels
Sep 21, 2023
poorbarcode
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left some minor comments.
/pulsarbot run-failure-checks |
mattisonchao
approved these changes
Sep 22, 2023
codelipenghui
approved these changes
Sep 22, 2023
/pulsarbot run-failure-checks |
lifepuzzlefun
approved these changes
Sep 23, 2023
liangyepianzhou
pushed a commit
that referenced
this pull request
Sep 25, 2023
(cherry picked from commit c632431)
Technoboy-
pushed a commit
that referenced
this pull request
Sep 25, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Sep 25, 2023
codelipenghui
pushed a commit
that referenced
this pull request
Oct 19, 2023
(cherry picked from commit c632431)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/metrics
cherry-picked/branch-2.10
cherry-picked/branch-2.11
cherry-picked/branch-3.0
cherry-picked/branch-3.1
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/2.10.6
release/2.11.3
release/3.0.2
release/3.1.1
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
AggregatedNamespaceStats is the object used when topic-level metrics are aggregated into namespace level, specifically when
exposeTopicLevelMetricsInPrometheus=false
.There is a loop which runs over all namespaces, and for each one, the same object is used, by first resetting it and then adding each topic metrics to it.
The existing
reset()
method lacks all fields hence some fields were accumulating over round of metrics reporting to prometheus metrics servlet, good example for it would bepulsar_out_bytes_total
.Modifications
I've fixed AggregatedNamespaceStats.reset() by including all the fields that were missing from it.
Verifying this change
(Please pick either of the following options)
This change added tests and can be verified as follows:
testReset()
method. I may add in subsequent PR a more generic way to validate we never forget to reset an added field.Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: asafm#3