[cleanup][broker] cleanup deprecated method of metadata store etcd

[liangyuanpeng]

Main Issue: #xyz

PIP: #xyz

Motivation

Use isPrefix insteadof deprecated method of withPrefix.

Modifications

Verifying this change

• Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

• Added integration tests for end-to-end deployment with large payloads (10MB)
• Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The threading model
• The binary protocol
• The REST endpoints
• The admin CLI options
• The metrics
• Anything that affects deployment

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository:

[github-actions]

@liangyuanpeng Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

[liangyuanpeng]

/pulsarbot rerun-failure-checks

[liangyuanpeng]

Failed CI for upload to codecov

[2023-10-11T04:31:04.218Z] ['info'] Pinging Codecov: https://codecov.io/upload/v4?package=github-action-3.1.4-uploader-0.6.3&token=*******&branch=cleanup_etcd_deprecated&build=6477302571&build_url=https%3A%2F%2Fgithub.com%2Fapache%2Fpulsar%2Factions%2Fruns%2F6477302571&commit=382319cdf725f045c90e27909052e0383c0f3876&job=Pulsar+CI+Flaky&pr=21253&service=github-actions&slug=apache%2Fpulsar&name=&tag=&flags=unittests&parent=
[2023-10-11T04:31:04.218Z] ['verbose'] Passed token was 0 characters long
[2023-10-11T04:31:04.218Z] ['verbose'] https://codecov.io/upload/v4?package=github-action-3.1.4-uploader-0.6.3&branch=cleanup_etcd_deprecated&build=6477302571&build_url=https%3A%2F%2Fgithub.com%2Fapache%2Fpulsar%2Factions%2Fruns%2F6477302571&commit=382319cdf725f045c90e27909052e0383c0f3876&job=Pulsar+CI+Flaky&pr=21253&service=github-actions&slug=apache%2Fpulsar&name=&tag=&flags=unittests&parent=
        Content-Type: 'text/plain'
        Content-Encoding: 'gzip'
        X-Reduced-Redundancy: 'false'
[2023-10-11T04:31:04.439Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}
[2023-10-11T04:31:04.440Z] ['verbose'] The error stack is: Error: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}
    at main (/snapshot/repo/dist/src/index.js)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
[2023-10-11T04:31:04.440Z] ['verbose'] End of uploader: 1396 milliseconds
Error: Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v3/dist/codecov' failed with exit code 255
Run sleep 60
Run codecov/codecov-action@v3
{
  execArgs: [
    '-n',
    '',
    '-Q',
    'github-action-3.1.4',
    '-Z',
    '-F',
    'unittests',
    '-C',
    '382319cdf725f045c90e27909052e0383c0f3876',
    '-v'
  ]
}
==> linux OS detected

[liangyuanpeng]

/pulsarbot rerun-failure-checks

[codecov-commenter]

Codecov Report

Merging #21253 (a94dcbf) into master (f25b082) will increase coverage by 38.90%.
Report is 6 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files

@@              Coverage Diff              @@
##             master   #21253       +/-   ##
=============================================
+ Coverage     34.49%   73.39%   +38.90%     
- Complexity    12116    32764    +20648     
=============================================
  Files          1716     1893      +177     
  Lines        131152   140754     +9602     
  Branches      14327    15503     +1176     
=============================================
+ Hits          45236   103307    +58071     
+ Misses        79828    29354    -50474     
- Partials       6088     8093     +2005     

Flag	Coverage Δ
inttests	24.10% <27.27%> (?)
systests	24.70% <18.18%> (-0.03%)	⬇️
unittests	72.69% <100.00%> (+40.90%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...che/bookkeeper/mledger/impl/ManagedLedgerImpl.java	80.78% <100.00%> (+34.60%)	⬆️
...org/apache/pulsar/broker/ServiceConfiguration.java	99.38% <100.00%> (+1.32%)	⬆️
...er/service/persistent/GeoPersistentReplicator.java	67.00% <100.00%> (+29.00%)	⬆️
...rg/apache/pulsar/compaction/TwoPhaseCompactor.java	78.15% <100.00%> (+10.08%)	⬆️
...apache/pulsar/metadata/impl/EtcdMetadataStore.java	81.01% <100.00%> (+80.59%)	⬆️

... and 1475 files with indirect coverage changes