-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][txn]Handle exceptions in the transaction pending ack init #21274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangyepianzhou
added
doc-not-needed
Your PR changes do not impact docs
and removed
doc-label-missing
labels
Oct 17, 2023
liangyepianzhou
requested review from
codelipenghui,
poorbarcode and
congbobo184
October 20, 2023 03:26
poorbarcode
reviewed
Oct 20, 2023
...src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java
Outdated
Show resolved
Hide resolved
poorbarcode
reviewed
Oct 20, 2023
...src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java
Show resolved
Hide resolved
liangyepianzhou
changed the title
[fix][txn]Remove subscription after transaction pending ack init failed.
[fix][txn]Handle exceptions in the transaction pending ack init
Oct 23, 2023
codelipenghui
requested changes
Oct 27, 2023
...src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/apache/pulsar/broker/transaction/pendingack/PendingAckPersistentTest.java
Outdated
Show resolved
Hide resolved
codelipenghui
added
type/bug
The PR fixed a bug or issue reported a bug
area/transaction
release/2.10.6
category/reliability
The function does not work properly in certain specific environments or failures. e.g. data lost
release/3.1.2
release/3.0.3
release/2.11.4
labels
Oct 27, 2023
...src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/apache/pulsar/broker/transaction/pendingack/PendingAckPersistentTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/apache/pulsar/broker/transaction/pendingack/PendingAckPersistentTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/apache/pulsar/broker/transaction/pendingack/PendingAckPersistentTest.java
Outdated
Show resolved
Hide resolved
liangyepianzhou
force-pushed
the
remove_failed_sub
branch
2 times, most recently
from
November 16, 2023 15:15
396e729
to
52612cb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21274 +/- ##
============================================
+ Coverage 73.57% 73.87% +0.30%
- Complexity 32624 32991 +367
============================================
Files 1877 1885 +8
Lines 139502 140002 +500
Branches 15299 15353 +54
============================================
+ Hits 102638 103429 +791
+ Misses 28908 28606 -302
- Partials 7956 7967 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Seems |
1. Add a serverError `TransactionComponentLoadFailed` 2. Add a new PulsarClientException `TransactionComponentLoadFailedException`. 2. Add a new BrokerServiceException `TransactionComponentLoadFailedException`. (cherry picked from commit 5d5b51f)
1. Add a timer and backoff to retry for retryable exception. 2. Return `TransactionComponentLoadFailed` error to client when encounter no-retryable exception.
Test build consumer with retryable exception and no-retryable exception.
This reverts commit 6d23c0d.
shibd
force-pushed
the
remove_failed_sub
branch
from
April 14, 2024 13:00
c5ffbf9
to
7f589de
Compare
shibd
pushed a commit
that referenced
this pull request
Apr 15, 2024
Co-authored-by: Baodi Shi <baodi@apache.org> (cherry picked from commit 5d18ff7)
shibd
pushed a commit
that referenced
this pull request
Apr 15, 2024
Co-authored-by: Baodi Shi <baodi@apache.org> (cherry picked from commit 5d18ff7)
shibd
pushed a commit
that referenced
this pull request
Apr 15, 2024
Co-authored-by: Baodi Shi <baodi@apache.org> (cherry picked from commit 5d18ff7)
shibd
pushed a commit
that referenced
this pull request
Apr 15, 2024
Co-authored-by: Baodi Shi <baodi@apache.org> (cherry picked from commit 5d18ff7)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 16, 2024
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 17, 2024
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 17, 2024
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 19, 2024
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/transaction
category/reliability
The function does not work properly in certain specific environments or failures. e.g. data lost
cherry-picked/branch-2.11
cherry-picked/branch-3.0
cherry-picked/branch-3.1
cherry-picked/branch-3.2
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/2.10.6
release/2.11.4
release/3.0.5
release/3.1.3
release/3.1.4
release/3.2.3
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopen #20927
Motivation
Transaction Pending ack is a component of persistent subscription. When creating or loading a subscription, If the subscription has a transaction pending ack, the transaction pending ack of this subscription needs to read data from the bookkeeper to recover it.
If the pending ack recovery failed, the subscription could not provide service anymore. And there is no processing logic for recovery failure.
pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java
Lines 157 to 172 in 403faa4
Modifications
If a retryable exception is encountered, recover again. Otherwise, a
TransactionComponentLoadFailedException
exception is returned.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: