Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] [metadata] Fix zookeeper related flacky test #21310

Merged
merged 7 commits into from
Oct 8, 2023

Conversation

horizonzy
Copy link
Member

@horizonzy horizonzy commented Oct 7, 2023

Fixes #21286, #21289

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

@horizonzy Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-label-missing doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Oct 7, 2023
@Technoboy- Technoboy- added this to the 3.2.0 milestone Oct 7, 2023
@Technoboy- Technoboy- closed this Oct 7, 2023
@Technoboy- Technoboy- reopened this Oct 7, 2023
@horizonzy horizonzy closed this Oct 8, 2023
@horizonzy horizonzy reopened this Oct 8, 2023
@horizonzy
Copy link
Member Author

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link

Codecov Report

Merging #21310 (f0e3a69) into master (643428b) will increase coverage by 36.28%.
Report is 5 commits behind head on master.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #21310       +/-   ##
=============================================
+ Coverage     36.96%   73.24%   +36.28%     
- Complexity    12294    32521    +20227     
=============================================
  Files          1698     1887      +189     
  Lines        130510   140223     +9713     
  Branches      14260    15435     +1175     
=============================================
+ Hits          48240   102709    +54469     
+ Misses        75982    29436    -46546     
- Partials       6288     8078     +1790     
Flag Coverage Δ
inttests 24.13% <66.66%> (-0.19%) ⬇️
systests 24.70% <66.66%> (-0.19%) ⬇️
unittests 72.54% <100.00%> (+40.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...org/apache/bookkeeper/mledger/util/RangeCache.java 95.40% <100.00%> (+21.53%) ⬆️

... and 1452 files with indirect coverage changes

@horizonzy
Copy link
Member Author

@hangc0276 @Technoboy- @poorbarcode Please help to review it.

@poorbarcode poorbarcode merged commit 9ab7417 into apache:master Oct 8, 2023
44 of 45 checks passed
@poorbarcode
Copy link
Contributor

Since the PR #21188 will cherry-pick into branch-3.0, branch-2.11 and branch-2.10 and the test is very flaky, I added the labels release/2.10.6, release/2.11.3 and release/3.0.2

poorbarcode pushed a commit that referenced this pull request Oct 8, 2023
Fix zookeeper related flacky test

(cherry picked from commit 9ab7417)
@lhotari
Copy link
Member

lhotari commented Oct 8, 2023

Great work @horizonzy!

@lhotari
Copy link
Member

lhotari commented Oct 9, 2023

This will help reduce flakiness a lot. Please cherry-pick also to branch-3.1 since that will be maintained for some time.

@horizonzy
Copy link
Member Author

This will help reduce flakiness a lot. Please cherry-pick also to branch-3.1 since that will be maintained for some time.

Sure.

liangyuanpeng pushed a commit to liangyuanpeng/pulsar that referenced this pull request Oct 11, 2023
horizonzy added a commit to horizonzy/pulsar that referenced this pull request Oct 11, 2023
Fix zookeeper related flacky test

(cherry picked from commit 9ab7417)
@horizonzy
Copy link
Member Author

This will help reduce flakiness a lot. Please cherry-pick also to branch-3.1 since that will be maintained for some time.

Done.

poorbarcode pushed a commit that referenced this pull request Oct 11, 2023
Fix zookeeper related flacky test

(cherry picked from commit 9ab7417)
vinayakmalik95 pushed a commit to tmdc-io/pulsar that referenced this pull request Oct 12, 2023
@horizonzy horizonzy deleted the fix-flaky-test branch October 12, 2023 08:16
shibd pushed a commit to shibd/pulsar that referenced this pull request Oct 22, 2023
Fix zookeeper related flacky test

(cherry picked from commit 9ab7417)
shibd pushed a commit to shibd/pulsar that referenced this pull request Oct 23, 2023
Fix zookeeper related flacky test

(cherry picked from commit 9ab7417)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Dec 20, 2023
Fix zookeeper related flacky test

(cherry picked from commit 9ab7417)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Dec 20, 2023
Fix zookeeper related flacky test

(cherry picked from commit 9ab7417)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment